Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3371247ybt; Tue, 23 Jun 2020 00:07:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUOHwVwQPQxUqQueMGhWSDda+gynjqPRMRDgtQF5NV3JIF+lFTJtM1Mts7+uSE7SNnG4ya X-Received: by 2002:a17:906:2cd5:: with SMTP id r21mr18411508ejr.20.1592896065596; Tue, 23 Jun 2020 00:07:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592896065; cv=none; d=google.com; s=arc-20160816; b=KTlHvuw6GR+k1dB/ZUGGvzi0hLZMNDc0ap57mSq5hCM/+IyWRXLNlA3uCuXmxW1nDh Y6rhKQE6kSIXKY1z0tj2fEQ5ZyMKOO5/s6DlEvJh0sFl6mM8OqimSfE41vdc0tTR7m/D 58FY8mNHT3uU8MY8xGDETZAV5AOx+BAXNonlo8CHYP+m9tyWOhiEJ6img6AlCm7VVuCf dDNed5l8BuTuEQ+koSoIN61hjVodDulgzy2dIRo++lOB8V9DHZjlFwLV2dLPPaVSsO/D 4Wrrl/8ZD9PtBuZwtb1aXEDbwe1EhbhyYrqTDdyqbW9u8AMnWC18NSJF3yGWzYZCV0J9 oD7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=4JVWCz8+lqtSop9dl2ZAnWPRN6EuY7Bv8qrsUVE3nXI=; b=lAjF/gNQr/eu1TcgzvDWkjODLmeer2cB3RDrVs96LuE2c3OdjPPuvSQbMB6XjHDMzr wYpI6lmwxMi6muWwGLVukEbH/yvjHxEsIh789q9gPzB/RumKFp+ZJjl5NYcGQDkhCzGd RwceRRmmUQrRg19PZgbb4LMQWHhKFyy+w6JtaOciStkW5L6oetM88xdc0g8A+uCqlByu xNrXYZYxBDuBCTmgbFJlrhs+k42w3gzDuPGFhtmuz5hezEkYErv73XJaSLnIeITVvi8W IOdJisNamxn+GEya0jPh+i0QGYCnQYsdESRa4Smd7FmBDCttTAL3jtuyG626kfqQ9lv0 6pqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=eOert1F3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d2si10154125ejw.702.2020.06.23.00.07.23; Tue, 23 Jun 2020 00:07:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=eOert1F3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731393AbgFWHDM (ORCPT + 99 others); Tue, 23 Jun 2020 03:03:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730830AbgFWHDM (ORCPT ); Tue, 23 Jun 2020 03:03:12 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23D34C061573; Tue, 23 Jun 2020 00:03:12 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id s10so9462481pgm.0; Tue, 23 Jun 2020 00:03:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4JVWCz8+lqtSop9dl2ZAnWPRN6EuY7Bv8qrsUVE3nXI=; b=eOert1F3W3A+fuUjzfaUw/OvDWW+QrwyruMv33b8OO6vVCo45o56Wqe2hKdpObJ6/k 0Mya8f7dxVC+Y0xaw5ty1qtaZjKs2W39IhD+HUmDbrHFGncL5wGhXqBOZCnceQNDqrm+ AdhnJF6heFeUcHGTdQPDrNlERwOJMkQ83wFl4QG2TRSnfaHzqeQ+WvSUwDNZnoCjNH4j IuH/Z3nqf8i5oHVwiAJixTbpYGr2nYXL5YUUQeOEE+1sguNP8TaLNDukiImeazNAMuyo CKL8TfrnChJdSJRDkC+Yk36DdtMWk+gCaA+CqIKtq68CuYvUiG1gxeP0pk+JkV4PsREL zMnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=4JVWCz8+lqtSop9dl2ZAnWPRN6EuY7Bv8qrsUVE3nXI=; b=bdvgGHRvsEQe2KKudQ9N8e86zBf1Kyj+Mzp0tCa7rP/YUFl50PvBvLRh/CQfFmLUi0 bDwpX1YRNdJYd4F+pnbxgzpJTkO8lqChimYy/2bJwWvvuxSSns+Coe4kgmUvQnIfjQdr L9gBk9236bcsw65zcbFUUAd+tTORJRwKY42cjlEUJVH7+wl7mR1m27rNI1NxDr83X2MX l8OeCOROaNhRXFKqykfMr0y5M+MLcMWMrNOx6LSwn0UzXIiZPPSTcvLk0HaPF0l/6xaP u0pilt1jhgE9T2oQuY0uwKVPJdPy/SKbrpj0bSFXuCX85AwCmwXqirtRwc13A1OK3S7k RegA== X-Gm-Message-State: AOAM5339cgXphQia6WptCgfMhIfvKcv1c8yy3fHRJoN2YQr6TUgg2STK yDZGWctYF7yNWoXvelsJ1cU= X-Received: by 2002:a63:7707:: with SMTP id s7mr15672418pgc.295.1592895791467; Tue, 23 Jun 2020 00:03:11 -0700 (PDT) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id z144sm16857370pfc.195.2020.06.23.00.03.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2020 00:03:09 -0700 (PDT) Date: Tue, 23 Jun 2020 00:03:08 -0700 From: Minchan Kim To: Greg Kroah-Hartman Cc: Nitin Gupta , Steffen Maier , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Wade Mealing , Sergey Senozhatsky , Jens Axboe Subject: Re: [PATCH v2] Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()" Message-ID: <20200623070308.GA186116@google.com> References: <20200617103412.GA2027053@kroah.com> <20200617114946.GA2131650@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200617114946.GA2131650@kroah.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2020 at 01:49:46PM +0200, Greg Kroah-Hartman wrote: > From: Wade Mealing > > Turns out that the permissions for 0400 really are what we want here, > otherwise any user can read from this file. > > [fixed formatting, added changelog, and made attribute static - gregkh] > > Reported-by: Wade Mealing > Cc: stable > Fixes: f40609d1591f ("zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()") > Link: https://bugzilla.redhat.com/show_bug.cgi?id=1847832 > Signed-off-by: Greg Kroah-Hartman Acked-by: Minchan Kim