Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200616220403.1807003-1-james.hilliard1@gmail.com>
 <20200622085321.GA3334@localhost> <CADvTj4rOYs6F3J2A72GiWGbYW_Fu7VNCd0GpWaJ9it6tEt+4Hw@mail.gmail.com>
 <20200623075348.GD3334@localhost>
In-Reply-To: <20200623075348.GD3334@localhost>
From:   James Hilliard <james.hilliard1@gmail.com>
Date:   Tue, 23 Jun 2020 02:08:57 -0600
Message-ID: <CADvTj4qn0nwyBY09pi5SZVuWHAZ65fVSUMA8QTAs1t0mYw6rmg@mail.gmail.com>
Subject: Re: [PATCH v2] USB: Serial: cypress_M8: Enable Simply Automated UPB PIM
To:     Johan Hovold <johan@kernel.org>
Cc:     linux-usb@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 23, 2020 at 1:53 AM Johan Hovold <johan@kernel.org> wrote:
>
> On Mon, Jun 22, 2020 at 11:04:09AM -0600, James Hilliard wrote:
> > On Mon, Jun 22, 2020 at 2:53 AM Johan Hovold <johan@kernel.org> wrote:
> > >
> > > On Tue, Jun 16, 2020 at 04:04:03PM -0600, James Hilliard wrote:
> > > > This is a UPB(Universal Powerline Bus) PIM(Powerline Interface Module)
> > > > which allows for controlling multiple UPB compatible devices from
> > > > Linux using the standard serial interface.
> > > >
> > > > Based on vendor application source code there are two different models
> > > > of USB based PIM devices in addition to a number of RS232 based PIM's.
> > > >
> > > > The vendor UPB application source contains the following USB ID's:
> > > > #define USB_PCS_VENDOR_ID 0x04b4
> > > > #define USB_PCS_PIM_PRODUCT_ID 0x5500
> > > >
> > > > #define USB_SAI_VENDOR_ID 0x17dd
> > > > #define USB_SAI_PIM_PRODUCT_ID 0x5500
> > > >
> > > > The first set of ID's correspond to the PIM variant sold by Powerline
> > > > Control Systems while the second corresponds to the Simply Automated
> > > > Incorporated PIM. As the product ID for both of these match the default
> > > > cypress HID->COM RS232 product ID it assumed that they both use an
> > > > internal variant of this HID->COM RS232 converter hardware. However
> > > > as the vendor ID for the Simply Automated variant is different we need
> > > > to also add it to the cypress_M8 driver so that it is properly
> > > > detected.
> > > >
> > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > > > ---
> > > > Changes v1 -> v2:
> > > >   - Add more detailed commit message.
> > >
> > > Now applied, thanks.
> > >
> > > Would you mind posting the output of "lsusb -v" for this device for
> > > completeness?
> > Bus 001 Device 004: ID 17dd:5500
> > Device Descriptor:
> >   bLength                18
> >   bDescriptorType         1
> >   bcdUSB               1.00
> >   bDeviceClass            0
> >   bDeviceSubClass         0
> >   bDeviceProtocol         0
> >   bMaxPacketSize0         8
> >   idVendor           0x17dd
> >   idProduct          0x5500
> >   bcdDevice            0.00
> >   iManufacturer           1 Simply Automated Inc.
> >   iProduct                2 USB to Serial
> >   iSerial                 0
> >   bNumConfigurations      1
> >   Configuration Descriptor:
> >     bLength                 9
> >     bDescriptorType         2
> >     wTotalLength       0x0029
> >     bNumInterfaces          1
> >     bConfigurationValue     1
> >     iConfiguration          4 Sample HID
> >     bmAttributes         0x80
> >       (Bus Powered)
> >     MaxPower              100mA
> >     Interface Descriptor:
> >       bLength                 9
> >       bDescriptorType         4
> >       bInterfaceNumber        0
> >       bAlternateSetting       0
> >       bNumEndpoints           2
> >       bInterfaceClass         3
> >       bInterfaceSubClass      0
> >       bInterfaceProtocol      0
> >       iInterface              0
> >         HID Device Descriptor:
> >           bLength                 9
> >           bDescriptorType        33
> >           bcdHID               1.00
> >           bCountryCode            0 Not supported
> >           bNumDescriptors         1
> >           bDescriptorType        34 Report
> >           wDescriptorLength      37
> >          Report Descriptors:
> >            ** UNAVAILABLE **
>
> Thanks for posting this.
>
> Don't you need to add this device to the HID driver's ignore list
> to prevent it from claiming the device (see hid_ignore_list) just like
> for the Cypress VID?
Ah, yeah, that does look to be needed, do you want to edit my patch or
should I send a follow up patch with that added?
>
> Johan