Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 23 Jun 2020 09:37:49 +0100
From:   Marc Zyngier <maz@kernel.org>
To:     Hanks Chen <hanks.chen@mediatek.com>
Cc:     CC Hwang <cc.hwang@mediatek.com>,
        Jason Cooper <jason@lakedaemon.net>, wsd_upstream@mediatek.com,
        Loda Chou <loda.chou@mediatek.com>,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-arm-kernel@lists.infradead.org, saravanak@google.com
Subject: Re: [PATCH 1/1] irqchip: Add config MTK_SYSIRQ and MTK_CIRQ
In-Reply-To: <1592894173.10773.42.camel@mtkswgap22>
References: <1592483471-14806-1-git-send-email-hanks.chen@mediatek.com>
 <f47e8a1e70c982ecf6245db573630f51@kernel.org>
 <1592490123.10773.16.camel@mtkswgap22>
 <1592894173.10773.42.camel@mtkswgap22>
User-Agent: Roundcube Webmail/1.4.5
Message-ID: <3dc953265ed4cd4300bd9600bf7e33d6@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

+ Saravana

On 2020-06-23 07:36, Hanks Chen wrote:

[...]

> Hi Marc,
> 
> I want to break the dependency between ARCH_MEDIATEK and CIRQ/SYSIRQ,
> because we need to follow the GKI.

This isn't what GKI mandates. GKI requires that the SoC code is compiled
as modules, not that it is dissociated from its platform (which would
be completely pointless).

> Could I add the MTK_CIRQ and MTK_SYSIRQ into defconfig?
> (arch/arm64/config/defconfig)

I don't deal with defconfig at all. That's a patch for the arm-soc 
people.

> 
> It would ensures all platform are executable.
> 
> e.g.
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> 
>  CONFIG_QCOM_PDC=y
> +CONFIG_MTK_SYSIRQ=m
> +CONFIG_MTK_CIRQ=y
>  CONFIG_RESET_QCOM_AOSS=y
> 
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -572,4 +572,18 @@ config LOONGSON_PCH_MSI
>         help
>           Support for the Loongson PCH MSI Controller.
> 
> +config MTK_SYSIRQ
> +       tristate "Mediatek interrupt polarity controller"
> +       depends on ARCH_MEDIATEK || COMPILE_TEST
> +       help
> +         Interrupt polarity controller driver to swap polarity for
> +         interrupts for Mediatek mobile chips.
> +
> +config MTK_CIRQ
> +       bool "Mediatek low-power interrupt controller"
> +       depends on ARCH_MEDIATEK || COMPILE_TEST
> +       help
> +         Low-power interrupt controller driver to monitor IRQS
> +         in the sleep mode for Mediatek mobile chips.
> +
> 
> 
> P.S I'll make the irq-mtk-sysirq driver as a loadable kernel module for
> GKI

You might as well turn both drivers into modules. Saravana was working
on a set of patches to ease this transition.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...