Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3425198ybt; Tue, 23 Jun 2020 01:51:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/+F6NTsjk13KPpJ8Tc7320d88cNbBvglrvmzFkfvuze+qhUL4qGbsldhylMOqP7vj/wLG X-Received: by 2002:a05:6402:1346:: with SMTP id y6mr9744433edw.192.1592902299933; Tue, 23 Jun 2020 01:51:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592902299; cv=none; d=google.com; s=arc-20160816; b=oXlrHV2n2tR6pEcw6BplahR5jG/3DT9Tgz+oudB8+GZ0jgeoJ+Nd4WCyttSbm0kYrP b78u9GFYJG6V5ePqqvXolKoo9cxrIXlupB6DbJPNixhb4fBQs05zl5avQ0K4oHXz6WrA xouVfKOMy2PPsCoJQFTL6a4d5U8NPZW7yOuiJOWNAD8jUC3PNvDbDjOE0VdMmSHD6i0B f1qIjqUjckDSqqYC/VpsbEN0HDZI4DQmYYDRXrwXj31CrmhfX6OKHN6HzYAqFm47zP5d YlWKVNz7b59jhA64bwazT5ttiogmRJZ1rHGLq7pf91cnT0hHwesJbwD9lBc4t/fW8uL0 v38A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :robot-unsubscribe:robot-id:message-id:mime-version:references :in-reply-to:cc:subject:to:reply-to:from:date; bh=gIfjnCSHyurQKKVhheDNo871Xu8yx6ATZ0PUAeZCX5Y=; b=akeZvsldnGIGSZKcTkcPfQj3aYEw6V5wpvva7ZlyzK6ShN2RDJBK2Y8gZryC7RjfKy CnZeUx+eMdmhzmt7qSDRqJizNDYP9mSN9XFs/KwyiH/3D053YgxV9cl9DyoSfQ8MZ/Mv qab+Ix0hfASwfh+seQpzR8KRtE81cyFJ5Bo29Sw3rJWFOg74ZRNwBb2Vrz54jj6aQfTP XSFAXI9XLwRiI5RaAwDrpe1AXBWV+nZVsuSUsiWjXc8/Z6S7mnrw9oJiwEjIrHAH+gNP s+Vw6RIq9kQtXkZcuSD9APSa0RWZM6F28pGjMmc1IUIK3KR56sbn5bNVOsTCJ5tkVDcF zVwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l20si11200351ejr.66.2020.06.23.01.51.17; Tue, 23 Jun 2020 01:51:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732005AbgFWIss (ORCPT + 99 others); Tue, 23 Jun 2020 04:48:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731909AbgFWIsc (ORCPT ); Tue, 23 Jun 2020 04:48:32 -0400 Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33D8FC061573; Tue, 23 Jun 2020 01:48:32 -0700 (PDT) Received: from [5.158.153.53] (helo=tip-bot2.lab.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jnebS-0005Ry-3J; Tue, 23 Jun 2020 10:48:26 +0200 Received: from [127.0.1.1] (localhost [IPv6:::1]) by tip-bot2.lab.linutronix.de (Postfix) with ESMTP id B0DD91C0470; Tue, 23 Jun 2020 10:48:25 +0200 (CEST) Date: Tue, 23 Jun 2020 08:48:25 -0000 From: "tip-bot2 for Juri Lelli" Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/urgent] sched/deadline: Initialize ->dl_boosted Cc: syzbot+5ac8bac25f95e8b221e7@syzkaller.appspotmail.com, Juri Lelli , "Peter Zijlstra (Intel)" , Ingo Molnar , Daniel Wagner , x86 , LKML In-Reply-To: <20200617072919.818409-1-juri.lelli@redhat.com> References: <20200617072919.818409-1-juri.lelli@redhat.com> MIME-Version: 1.0 Message-ID: <159290210552.16989.700196687000578235.tip-bot2@tip-bot2> X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the sched/urgent branch of tip: Commit-ID: 1863cc11225e3ea2cd005473f9addc52513ab1bc Gitweb: https://git.kernel.org/tip/1863cc11225e3ea2cd005473f9addc52513ab1bc Author: Juri Lelli AuthorDate: Wed, 17 Jun 2020 09:29:19 +02:00 Committer: Ingo Molnar CommitterDate: Tue, 23 Jun 2020 10:42:39 +02:00 sched/deadline: Initialize ->dl_boosted syzbot reported the following warning triggered via SYSC_sched_setattr(): WARNING: CPU: 0 PID: 6973 at kernel/sched/deadline.c:593 setup_new_dl_entity /kernel/sched/deadline.c:594 [inline] WARNING: CPU: 0 PID: 6973 at kernel/sched/deadline.c:593 enqueue_dl_entity /kernel/sched/deadline.c:1370 [inline] WARNING: CPU: 0 PID: 6973 at kernel/sched/deadline.c:593 enqueue_task_dl+0x1c17/0x2ba0 /kernel/sched/deadline.c:1441 This happens because the ->dl_boosted flag is currently not initialized by __dl_clear_params() (unlike the other flags) and setup_new_dl_entity() rightfully complains about it. Initialize dl_boosted to 0. Fixes: 2d3d891d3344 ("sched/deadline: Add SCHED_DEADLINE inheritance logic") Reported-by: syzbot+5ac8bac25f95e8b221e7@syzkaller.appspotmail.com Signed-off-by: Juri Lelli Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ingo Molnar Tested-by: Daniel Wagner Link: https://lkml.kernel.org/r/20200617072919.818409-1-juri.lelli@redhat.com --- kernel/sched/deadline.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 504d2f5..f63f337 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -2692,6 +2692,7 @@ void __dl_clear_params(struct task_struct *p) dl_se->dl_bw = 0; dl_se->dl_density = 0; + dl_se->dl_boosted = 0; dl_se->dl_throttled = 0; dl_se->dl_yielded = 0; dl_se->dl_non_contending = 0;