Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200212101651.9010-1-geert+renesas@glider.be>
 <CAEbi=3fMRq++Eot+BEtCedeyhM65kTc+nS7=inCTR8MkT5srww@mail.gmail.com> <CAMuHMdU+VLpg5Yezo2Ea9v2vmvbA=nEcKObBgZYwjSV10OkY=A@mail.gmail.com>
In-Reply-To: <CAMuHMdU+VLpg5Yezo2Ea9v2vmvbA=nEcKObBgZYwjSV10OkY=A@mail.gmail.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 23 Jun 2020 10:49:07 +0200
Message-ID: <CAMuHMdWaRw+61y4Ykk4niagPOtY3dL28fhtB=3jdR16ZODGgfg@mail.gmail.com>
Subject: Re: [PATCH] nds32: Replace <linux/clk-provider.h> by <linux/of_clk.h>
To:     Greentime Hu <green.hu@gmail.com>
Cc:     Nick Hu <nickhu@andestech.com>, Vincent Chen <deanbo422@gmail.com>,
        linux-clk <linux-clk@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Greentime,

On Wed, Feb 12, 2020 at 1:25 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Wed, Feb 12, 2020 at 11:52 AM Greentime Hu <green.hu@gmail.com> wrote:
> > Geert Uytterhoeven <geert+renesas@glider.be> 於 2020年2月12日 週三 下午6:16寫道：
> > > The Andes platform code is not a clock provider, and just needs to call
> > > of_clk_init().
> > >
> > > Hence it can include <linux/of_clk.h> instead of <linux/clk-provider.h>.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > >  arch/nds32/kernel/time.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/nds32/kernel/time.c b/arch/nds32/kernel/time.c
> > > index ac9d78ce3a818926..574a3d0a853980a9 100644
> > > --- a/arch/nds32/kernel/time.c
> > > +++ b/arch/nds32/kernel/time.c
> > > @@ -2,7 +2,7 @@
> > >  // Copyright (C) 2005-2017 Andes Technology Corporation
> > >
> > >  #include <linux/clocksource.h>
> > > -#include <linux/clk-provider.h>
> > > +#include <linux/of_clk.h>
> > >
> > >  void __init time_init(void)
> > >  {
> >
> > Thank you, Geert.
> >
> > Let me know if you like to put in your tree or nds32's.
> > Acked-by: Greentime Hu <green.hu@gmail.com>
>
> Please take it in the nds32 tree.
> Thanks!

And so you did. But it disappeared after June 12, when the nds32 tree
was reset to v5.7, losing the following 2 commits:

de9a5650b611014c52b1ad994f63253593d8eddf nds32: Replace
<linux/clk-provider.h> by <linux/of_clk.h>
d785c5a324cd8812720a409dc85050558281a567 nds32: configs: Cleanup
CONFIG_CROSS_COMPILE

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds