Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3608095ybt; Tue, 23 Jun 2020 06:38:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9DCW9cIEta7+Kg3jU5dwxv8upySf7Mc3aqoywi+JeTN5G0LFjtKfNS5zg+j2PV6OJWkhJ X-Received: by 2002:a17:906:7c07:: with SMTP id t7mr14870569ejo.487.1592919531698; Tue, 23 Jun 2020 06:38:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592919531; cv=none; d=google.com; s=arc-20160816; b=ldfxsH6ITvPYPBh+7wq7iYdveQtCuCTk0+STP0QEZ9ooR5KKcmMcmW4eLIF7q9a9sm JrdUYM2pFhvvj+ROxEP2SNH5NjhUaWiNjV3r711zUloRIIZgJ8DqUp/BOzZcoxFWmhc0 XTmm0y0cffYltin5YIi2BbpISeFqyFPRAUlsuodYeYkVDvVugZkPHzWVqkUROmPWzIJG 0oabjUWTOpPuoElyyhOWhsKrr10XnaEZSLFN32Pu8Qgcy5HcnWWRV2zHK7aCVXk1quM4 /amZcBQkmKbCsJkamCwqKhaGYoP3M0tb4xG+3J79c4QWQcJylS/OUadHL84xWijMMuja s+ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date; bh=820DIwfFi/4pP5gCSbMkzx2Heio9a+tGqguVGSo+HAg=; b=rE9oyRSP0/WTWcC5u/+kHDqSyKo2U3iJ/GNeGuKdr+PIefHxSmtRurEWbXcUU5gYea 94LeCKJocd83kV4xry4uVoqMdQr48RKNzrdFStthR28jvykb+hkQd+MHBixnABp6gPHo L6jJCMURZ6aBd5cYA8M34B6472qr8BM3c8CLMJJdQj4KeJfFRHTW/oZQ6yoldHx0Nj23 IuRDc+WjVbfVw1UT8hOL+vXHBdPhn7yWOzSYquchgFjMMBOYmsPYU86OgCoVY7OxdENT 5Y5Vhx47BquI4EPfTP3M+c0YD+gUo8m1UuGnjhKTc18+aKVY2eYhjC36WjrHm+rkevtB F+8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d2si10627480ejw.702.2020.06.23.06.38.28; Tue, 23 Jun 2020 06:38:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732731AbgFWNfh (ORCPT + 99 others); Tue, 23 Jun 2020 09:35:37 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:59580 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732662AbgFWNfc (ORCPT ); Tue, 23 Jun 2020 09:35:32 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id DDF911C0C0F; Tue, 23 Jun 2020 15:35:30 +0200 (CEST) Date: Tue, 23 Jun 2020 15:35:30 +0200 From: Pavel Machek To: Ond??ej Jirman , Sam Ravnborg , linux-sunxi@googlegroups.com, Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Linus Walleij , Icenowy Zheng , devicetree@vger.kernel.org, Samuel Holland , Bhushan Shah , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Luca Weiss , Martijn Braam , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 3/5] drm: panel: Add Xingbangda XBD599 panel (ST7703 controller) Message-ID: <20200623133529.GC2783@bug> References: <20200617003209.670819-1-megous@megous.com> <20200617003209.670819-4-megous@megous.com> <20200620212529.GB74146@ravnborg.org> <20200620223010.fqjwijiixxkewk3p@core.my.home> <20200622080802.GA650963@ravnborg.org> <20200622111752.jsz37zl7hidvkozw@core.my.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200622111752.jsz37zl7hidvkozw@core.my.home> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > > > Would it not be better to have one st7703 driver that suipports both > > > > panels? > > > > > > > > The driver would need dedicated init functions depending on the panel. > > > > But a lot could also be shared. > > > > > > I guess I can move the code there. > > In the same process the river should then be renamed to follow other > > sitronix based drivers. > > So the next developer will recognize this and use the correct driver. > > Are driver/module names considered kernel ABI? Or is it possible to > change them? I believe you can get away with changing them. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html