Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750959AbWC0MYr (ORCPT ); Mon, 27 Mar 2006 07:24:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750960AbWC0MYr (ORCPT ); Mon, 27 Mar 2006 07:24:47 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:36325 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S1750959AbWC0MYr (ORCPT ); Mon, 27 Mar 2006 07:24:47 -0500 Date: Mon, 27 Mar 2006 14:24:15 +0200 From: Pavel Machek To: Con Kolivas Cc: "Rafael J. Wysocki" , Nick Piggin , linux list , ck list , Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH] mm: swsusp shrink_all_memory tweaks Message-ID: <20060327122415.GC1766@elf.ucw.cz> References: <200603200231.50666.kernel@kolivas.org> <200603202250.14843.kernel@kolivas.org> <200603201946.32681.rjw@sisk.pl> <200603241807.41175.kernel@kolivas.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200603241807.41175.kernel@kolivas.org> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1079 Lines: 29 Hi! > > swsusp_shrink_memory() is still wrong, because it will always fail for > > image_size = 0. My bad, sorry. > > > > The appended patch (on top of yours) should fix that (hope I did it right > > this time). > > Well I discovered that if all the necessary memory is freed in one call to > shrink_all_memory we don't get the nice updating printout from > swsusp_shrink_memory telling us we're making progress. So instead of > modifying the function to call shrink_all_memory with the full amount (and > since we've botched swsusp_shrink_memory a few times between us), we should > limit it to a max of SHRINK_BITEs instead. > > This patch is fine standalone. > > Rafael, Pavel what do you think of this one? Looks good to me (but I'm not a mm expert). Pavel -- Picture of sleeping (Linux) penguin wanted... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/