Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5DBDEC433C6
Reply-To: <bcain@codeaurora.org>
From:   "Brian Cain" <bcain@codeaurora.org>
To:     "'Christian Brauner'" <christian.brauner@ubuntu.com>,
        <linux-kernel@vger.kernel.org>
Cc:     "'Linus Torvalds'" <torvalds@linux-foundation.org>,
        <linux-hexagon@vger.kernel.org>
References: <20200622234326.906346-1-christian.brauner@ubuntu.com> <20200622234326.906346-12-christian.brauner@ubuntu.com>
In-Reply-To: <20200622234326.906346-12-christian.brauner@ubuntu.com>
Subject: RE: [PATCH 11/17] hexagon: switch to copy_thread_tls()
Date:   Tue, 23 Jun 2020 11:11:37 -0500
Message-ID: <14e701d64978$f9a2af60$ece80e20$@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AQHblW6eodCfbmmuDWKuTMw/1BiW7AJ/OGz0qMfM2cA=
Content-Language: en-us
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

...
> Cc: Brian Cain <bcain@codeaurora.org>
> Cc: linux-hexagon@vger.kernel.org
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> ---
>  arch/hexagon/Kconfig          | 1 +
>  arch/hexagon/kernel/process.c | 6 +++---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig index
> 667cfc511cf9..19bc2f2ee331 100644
> --- a/arch/hexagon/Kconfig
> +++ b/arch/hexagon/Kconfig
> @@ -31,6 +31,7 @@ config HEXAGON
>  	select GENERIC_CLOCKEVENTS_BROADCAST
>  	select MODULES_USE_ELF_RELA
>  	select GENERIC_CPU_DEVICES
> +	select HAVE_COPY_THREAD_TLS
>  	help
>  	  Qualcomm Hexagon is a processor architecture designed for high
>  	  performance and low power across a wide variety of applications.
> diff --git a/arch/hexagon/kernel/process.c b/arch/hexagon/kernel/process.c
> index ac07f5f4b76b..d756f9556dd7 100644
> --- a/arch/hexagon/kernel/process.c
> +++ b/arch/hexagon/kernel/process.c
> @@ -50,8 +50,8 @@ void arch_cpu_idle(void)
>  /*
>   * Copy architecture-specific thread state
>   */
> -int copy_thread(unsigned long clone_flags, unsigned long usp,
> -		unsigned long arg, struct task_struct *p)
> +int copy_thread_tls(unsigned long clone_flags, unsigned long usp,
> +		    unsigned long arg, struct task_struct *p, unsigned long
tls)
>  {
>  	struct thread_info *ti = task_thread_info(p);
>  	struct hexagon_switch_stack *ss;
> @@ -100,7 +100,7 @@ int copy_thread(unsigned long clone_flags, unsigned
> long usp,
>  	 * ugp is used to provide TLS support.
>  	 */
>  	if (clone_flags & CLONE_SETTLS)
> -		childregs->ugp = childregs->r04;
> +		childregs->ugp = tls;
> 
>  	/*
>  	 * Parent sees new pid -- not necessary, not even possible at
> --
> 2.27.0

Acked-by: Brian Cain <bcain@codeaurora.org>