Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750735AbWC0RPU (ORCPT ); Mon, 27 Mar 2006 12:15:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750746AbWC0RPU (ORCPT ); Mon, 27 Mar 2006 12:15:20 -0500 Received: from ns.virtualhost.dk ([195.184.98.160]:14400 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S1750735AbWC0RPS (ORCPT ); Mon, 27 Mar 2006 12:15:18 -0500 Date: Mon, 27 Mar 2006 19:15:21 +0200 From: Jens Axboe To: OGAWA Hirofumi Cc: Brandon Low , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: 2.6.16-mm1 Message-ID: <20060327171520.GO8186@suse.de> References: <20060324024540.GM27559@lostlogicx.com> <20060323185810.3bf2a4ce.akpm@osdl.org> <20060324032126.GN27559@lostlogicx.com> <20060324033934.161302c1.akpm@osdl.org> <20060324125817.GB3381@lostlogicx.com> <20060324103301.4e6c5a4b.akpm@osdl.org> <20060324183734.GC4173@suse.de> <20060324191506.GC3381@lostlogicx.com> <20060327105811.GG8186@suse.de> <8764lzony4.fsf@duaron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8764lzony4.fsf@duaron.myhome.or.jp> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1356 Lines: 39 On Tue, Mar 28 2006, OGAWA Hirofumi wrote: > Jens Axboe writes: > > > On Fri, Mar 24 2006, Brandon Low wrote: > > > > Hmm, no luck reproducing this so far, strange. I'm using > > 2.6.16-block.git cfq branch exclusively, which is the patch you backed > > out. I guess I'll try 2.6.16-mm1 on the same box next. > > > > Can you try 2.6.16-mm1 with this patch applied on top? > > > > diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c > > index 81edf51..89fcc2c 100644 > > --- a/block/cfq-iosched.c > > +++ b/block/cfq-iosched.c > > @@ -1516,6 +1516,7 @@ cfq_cic_rb_add(struct cfq_data *cfqd, st > > > > rb_link_node(&cic->rb_node, parent, p); > > rb_insert_color(&cic->rb_node, &ioc->cic_root); > > + list_add(&cic->queue_list, &cfqd->cic_list); > > read_unlock(&cfq_exit_lock); > > } > > I've got a same oops in 2.6.16-mm1, and this patch seems to fix it at > least in my case. Super, it should fix it afaict, but not being able to reproduce I could not say for sure. Thanks very much for testing and reporting back. Andrew, can you enable cfq pull again? Thanks. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/