Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp10132ybt; Tue, 23 Jun 2020 13:55:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxolu2e28+gHknPbNH3jLvsH2YGnpWo6CM9Z3/ox2+ZpcaGq9ixP64Xoh2Dm1n+7miNFvig X-Received: by 2002:a17:906:b74e:: with SMTP id fx14mr7804140ejb.202.1592945751691; Tue, 23 Jun 2020 13:55:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592945751; cv=none; d=google.com; s=arc-20160816; b=z70BK9GqWDRlaSapZXftNMKZGzdY2YuwnoHDLkPRt5Mbs61l3AByTTkDYy8O21oIr+ UqKHk+sjXZbrxMxQA/2vOvuz+mHMqTJ/CMH+8fJICbfrsQgUAhXVTge1alNJezE/PDZN j7sWaNO49MjXHMdmulsYCZ4MeDsKDMfK+qjcGwrI6DKfejPJPVvp4SbBF14k9cAGrx89 hyYphbSAYkY2Qtc5ICpRB4mSxvdsGKdwSERazguxiDh7cGSvq2aR6Hs1LNenXILMeAi9 dbJ04CGQPDew4tP2OLUL0FEwsB6SeONEfBW56dXK1Q48dkFtlR97BAEeVz15hvXrh//Y +Fgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=k5BLuxN/7LjkXzUmNS9i5PFhWORxBAknZh4mcjW8bvA=; b=FTb5LsyKv9r8zNtXGOZALc+6LVgy4jGiUpylW0Fe+XtuanpEmks2UPBKltGik9PORX dmY9lxO0QSecV7YylUZk2JyePaBF1Azr4nh2yR/LIftHYbrTZ8VrYBJyqh0SQ28s2uXX IV2PpqvwkR7J5omau2fpV0+E4qTMynPZ8nLhuv94+LI042xhu7p7cNhZbApTz/mUjHQF srBU7unOvA/AgbnD1mLdEWtZSg8BDTivP7z+DP89GD/Azm83CVT8qaUFm2LRHJ22dzrk fr8KsQMjkSPuUYmVdsiL6JkbqhKuOPN37i9kHHbIlJItUNDwM1yT6VHii8fgOWRIZAGQ XHxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=S0bhQaYd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v28si13853122edd.233.2020.06.23.13.55.28; Tue, 23 Jun 2020 13:55:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=S0bhQaYd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392885AbgFWUyC (ORCPT + 99 others); Tue, 23 Jun 2020 16:54:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:43966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392812AbgFWUqK (ORCPT ); Tue, 23 Jun 2020 16:46:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2ACF20656; Tue, 23 Jun 2020 20:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945170; bh=3PieOHKjOMnnP/PntUMhwvBzOEIN+HGFDWq+bL2vmMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S0bhQaYd0agwJnwIj7zo52i6loKDc1De3kid1GQ8eJyjSdwDMDRzUbHolmYaOquz2 mcVdvDfUVdVGjgerbjX4OI+mZeieHOiGmzrESbEaVg6bPBwDJsMqBCYAuT0umDDWlY Kjx44aROZ+FQoWw+JmAtzN3Ton0NTp87Kp0w55TE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tyrel Datwyler , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.14 035/136] scsi: ibmvscsi: Dont send host info in adapter info MAD after LPM Date: Tue, 23 Jun 2020 21:58:11 +0200 Message-Id: <20200623195305.402839726@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195303.601828702@linuxfoundation.org> References: <20200623195303.601828702@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tyrel Datwyler [ Upstream commit 4919b33b63c8b69d8dcf2b867431d0e3b6dc6d28 ] The adapter info MAD is used to send the client info and receive the host info as a response. A persistent buffer is used and as such the client info is overwritten after the response. During the course of a normal adapter reset the client info is refreshed in the buffer in preparation for sending the adapter info MAD. However, in the special case of LPM where we reenable the CRQ instead of a full CRQ teardown and reset we fail to refresh the client info in the adapter info buffer. As a result, after Live Partition Migration (LPM) we erroneously report the host's info as our own. [mkp: typos] Link: https://lore.kernel.org/r/20200603203632.18426-1-tyreld@linux.ibm.com Signed-off-by: Tyrel Datwyler Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/ibmvscsi/ibmvscsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index 83645a1c6f82e..aff868afe68d0 100644 --- a/drivers/scsi/ibmvscsi/ibmvscsi.c +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c @@ -429,6 +429,8 @@ static int ibmvscsi_reenable_crq_queue(struct crq_queue *queue, int rc = 0; struct vio_dev *vdev = to_vio_dev(hostdata->dev); + set_adapter_info(hostdata); + /* Re-enable the CRQ */ do { if (rc) -- 2.25.1