Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp36592ybt; Tue, 23 Jun 2020 14:38:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqWtTZeXcFEJRi+ylNQDz7qkhcj/O5XdfyY+COCuZIN+lGSnATnToKKiyffxMU3KcOUD11 X-Received: by 2002:a17:906:455:: with SMTP id e21mr11326359eja.550.1592948303536; Tue, 23 Jun 2020 14:38:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592948303; cv=none; d=google.com; s=arc-20160816; b=aW7vpy06nkrF3sUgB1pgFcoMudgUneQqvVvxi77mb12iZDUT416aa2QG61hpZxLQt6 JLiDdEc2zgZEKJxr49cx69odnn9Q557pXTfcWzvTthmAGLHIZ5wdpdQkmdRV5beVjqF7 hN0WbRSR6wc2hYoUtFfjwkDIndaprdBjUAobebMU8CVK9Vm+PirnMaDK08FBBV2gswmE XSt0Rw5eFozcJcRKYn3sdwQHK8uhFjWjp1q5LRi8xwCxDTPyueIEf3+Fsk22kzLwMHRa JdVFPQ5qBe4ad0/V6lJR97atjTprVP+wwek69lOdNM6cuKGA2PKkrdHb53t1DvOQCuuK BfMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=1KP6S2LoW8K5RQjtOaGrIy+W1LvL+JVlHk3Be05vzK0=; b=ExrF4D/AYw3cx1F0lF4oM/QXS9bJqlj1r6B8wKc0X4W/6SCwZsrax0oXRjFv0KJRKm WBoIYLL90HoASWUf5IKBk1D2jZAduxNBZx/a8FnLiWHkpOV45bgORNyjfJWigLOSQE64 EfdNn78l3XSKNYArKLaFmiEGtIJDPSoFCQUuNdjk29nZg1cEMaEhLNAkP1ZN1Rz2xrTZ qC3L8KEitPYtgiyMsY7Nsx8si6NxShcs0FlcGhIEDijxBX/61A9jrRw1/WJIK7N25vYa 3VE0osX1hyPlbwvusIhKJL3MGQHHl/n1VzlaBiqHKBYtHUqVDtkU7G9yf4vlsV8upDk7 YyLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 60si7426510edp.566.2020.06.23.14.38.00; Tue, 23 Jun 2020 14:38:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389202AbgFWVed (ORCPT + 99 others); Tue, 23 Jun 2020 17:34:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387680AbgFWVeb (ORCPT ); Tue, 23 Jun 2020 17:34:31 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7827C061573; Tue, 23 Jun 2020 14:34:31 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5149D129428A8; Tue, 23 Jun 2020 14:34:31 -0700 (PDT) Date: Tue, 23 Jun 2020 14:34:30 -0700 (PDT) Message-Id: <20200623.143430.794983681368540702.davem@davemloft.net> To: Jisheng.Zhang@synaptics.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, linux@armlinux.org.uk, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] net: phy: export phy_disable_interrupts() From: David Miller In-Reply-To: <20200623154104.3ba15b4d@xhacker.debian> References: <20200623154031.736123a6@xhacker.debian> <20200623154104.3ba15b4d@xhacker.debian> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 23 Jun 2020 14:34:31 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jisheng Zhang Date: Tue, 23 Jun 2020 15:41:04 +0800 > +EXPORT_SYMBOL_GPL(phy_disable_interrupts); phy.o and phy_device.o are always linked together, therefore you don't need a module symbol export. If you plan to use it later in a device, submit the symbol export with the driver change that uses it.