Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20191003154533.590915454@linuxfoundation.org> <20191003154533.875309419@linuxfoundation.org>
In-Reply-To: <20191003154533.875309419@linuxfoundation.org>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Tue, 23 Jun 2020 16:07:50 -0600
Message-ID: <CAHmME9oNODYeVZZdgEqy+foSKZcBY51ZEujYCwymL0sU+R-5LA@mail.gmail.com>
Subject: Re: [PATCH 5.2 003/313] ipv6: do not free rt if FIB_LOOKUP_NOREF is
 set on suppress rule
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        stable <stable@vger.kernel.org>, Wei Wang <weiwan@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

I realize 5.2 has long since sunsetted, and I really missed the boat
on speaking up about this many many months ago, but in case any
distros or organizations have a 5.2.x stable series, this should
probably be reverted from 5.2. The reason is that 7d9e5f422 was added
to 5.3, and introduced a UaF, which this commit then fixed. But
without 7d9e5f422, this commit adds a memory leak.

Anyway, not worth spending too much brain cycles on this, considering
5.2 isn't even mentioned on kernel.org any more, but in case it helps
for somebody doing something strange in years to come, voila.