Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp114739ybt; Tue, 23 Jun 2020 16:52:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4Pkqsx9QlUz2UjyJY2b6KX8PL8HrCLfU4e5GoRlpLHNU+JXEvvLkUGvr+FlkECXNVkn8B X-Received: by 2002:aa7:d28d:: with SMTP id w13mr24475306edq.336.1592956329350; Tue, 23 Jun 2020 16:52:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592956329; cv=none; d=google.com; s=arc-20160816; b=v5Stam6JE2XnDv/AqaIUN2GwpCgKIZyZm4ajR+1DL6Vgdyaorpu7hS9Gsw6qAj1+aN iAxx6oNDsSmBFoKQNg7VZQWE8KMcG4VvUU3Oot4moRaq5bq3g45iAp4X4gZnhSWaWk0k b/dVIrezdijncKI84USAMgzGugz2L+A+PI3YvmxC40vaYl2sKpNqxb8H6FbLF6h7G1oH i+vVYQyEj9MR3vAlv2q9GInEvau/+1mH9T4wS1JWRtzHvNl1PgGW8+6/8/A73pj7/+Xt +HXhgrHzf0VBg7/7d9fMqz3oDI7feCUt1yofvfABgD4M1uVkll5ti2ZMsaUfu6c+HVdZ aHBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from :dkim-signature; bh=L91sjcIPUiXFRY3kZBjWIFZ3Rmo9m3IlVJuhftDX/3w=; b=TwB6cCIMGiLUwKKE6MfEUE+RDhXa1MZs56LyI3xIJ0gMWIiGIQtQhYvttOGIea7iOS 9CZKA+f0nY4crq1O/DO0Mthd7ZQ95P5HWBoN6HfGCuuziOPcJzG0demGc5je+BDqFRdi OQU5gKHN9wviKb2b89Vinto5/rRMPHCzFEgRtdGU9GzZykuxZZpQr3FVMtxfU+rKASpx nej3N2cpnpLNlQIxiCUr0s0yfT9P9ZQDT3+E0iiugvBDGB64hmFKVz1yG2wVgb4e0RZP SCUBpBwYLPyfAS+F6OECYQT5ZTX2xtsxBKo4iT3gO7R0lsp05CziVlVdLu0aasBuB3WP zsUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="i1/AqsCl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a2si13095994edr.468.2020.06.23.16.51.46; Tue, 23 Jun 2020 16:52:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="i1/AqsCl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387687AbgFWXtQ (ORCPT + 99 others); Tue, 23 Jun 2020 19:49:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387520AbgFWXtQ (ORCPT ); Tue, 23 Jun 2020 19:49:16 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEDECC061573 for ; Tue, 23 Jun 2020 16:49:14 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id b4so208837qkn.11 for ; Tue, 23 Jun 2020 16:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=L91sjcIPUiXFRY3kZBjWIFZ3Rmo9m3IlVJuhftDX/3w=; b=i1/AqsClIbSx/ctjq1bZpJG6zdCxn9EfKVGgjxOQjExpMbruBmfxThanjDNRBJsAcG n8sktsqfXgwT3HTM0AD1P24RWhLsluhZORp5jZ94yCf+dlv2/zx5foTD4ogoRt7RP9e3 i0PAe6thRw3/CxVyV05qyJEZVCZmGceBfh9SgYurP9LcxVJS9xNtJWhD9iRo/tmTNnMu 5FzGuDcTxY231n181zAVXx51YTyxBdTkkLg/Fzdibj140NvMqKEka5uUJev+xJpxBetp 9LPzliMMSoxjIg4ypryvDjBgR2/GSrt6dsy+f5t5oWdqii/uZ9pve7ZcCZYuftbwwB7s Auyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=L91sjcIPUiXFRY3kZBjWIFZ3Rmo9m3IlVJuhftDX/3w=; b=ND9gs2djgZ/VtccoffBGvdqToZ21Qd3UjS78e44mK0wSKQCCGP5cgUtc1DZTDlJD6H 65IFyZlkkliuIF1AS+UarRIlXOMF+DbRuuFfk7qPztHgEm2/Dlr84+eTENAJ9cQd9RIp 0hb4aeg0L8FEjRiD8etPFnw7TmPWhsrmtdF2AAoV2Fm+rfxyZiivRco3CiZ4K+biz4iC wMue+cPOjUWyQORlG6ljXzgiFOTKz45wBFVlWQSOidTq18beNNyg5nfBgG2yXaN/i2Ak Jg5lreh0fXhOggW/h17UR2F42WJ37LmquyTmklTMDSMJfAuhEWGZfQ3tS/jz8NV98PIL Qvfw== X-Gm-Message-State: AOAM533rYleX7ryD64E5NczsBGn/XvbzwMXVv7lu9UoM4NDUp1no61xG CpddtqNnupbmgTV8c8rB5B4= X-Received: by 2002:a05:620a:219c:: with SMTP id g28mr23274619qka.227.1592956153999; Tue, 23 Jun 2020 16:49:13 -0700 (PDT) Received: from linux.home ([2604:2000:1344:41d:596e:7d49:a74:946e]) by smtp.googlemail.com with ESMTPSA id o21sm2006501qtt.25.2020.06.23.16.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2020 16:49:13 -0700 (PDT) From: Gaurav Singh To: gaurav1086@gmail.com, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Mathieu Poirier , Ian Rogers , linux-kernel@vger.kernel.org (open list:PERFORMANCE EVENTS SUBSYSTEM) Subject: [PATCH] [perf] intel_pt_recording_options: Remove redundant intel_pt_evsel null check Date: Tue, 23 Jun 2020 19:48:50 -0400 Message-Id: <20200623234905.18608-1-gaurav1086@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org intel_pt_evsel cannot be NULL here since its already being dereferenced above. Remove this redundant check. Signed-off-by: Gaurav Singh --- tools/perf/arch/x86/util/intel-pt.c | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c index 839ef52c1ac2..8cc87fd2dc6f 100644 --- a/tools/perf/arch/x86/util/intel-pt.c +++ b/tools/perf/arch/x86/util/intel-pt.c @@ -836,19 +836,17 @@ static int intel_pt_recording_options(struct auxtrace_record *itr, } } - if (intel_pt_evsel) { - /* - * To obtain the auxtrace buffer file descriptor, the auxtrace - * event must come first. - */ - perf_evlist__to_front(evlist, intel_pt_evsel); - /* - * In the case of per-cpu mmaps, we need the CPU on the - * AUX event. - */ - if (!perf_cpu_map__empty(cpus)) - evsel__set_sample_bit(intel_pt_evsel, CPU); - } + /* + * To obtain the auxtrace buffer file descriptor, the auxtrace + * event must come first. + */ + perf_evlist__to_front(evlist, intel_pt_evsel); + /* + * In the case of per-cpu mmaps, we need the CPU on the + * AUX event. + */ + if (!perf_cpu_map__empty(cpus)) + evsel__set_sample_bit(intel_pt_evsel, CPU); /* Add dummy event to keep tracking */ if (opts->full_auxtrace) { -- 2.17.1