Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp221530ybt; Tue, 23 Jun 2020 20:12:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQnSIXWu8uGCQiQNkHwZw0pQjwEDBtCikOje2V1HuV/AtQFMpjW9hsW4at6+7KrROqPJgF X-Received: by 2002:a17:906:d290:: with SMTP id ay16mr10327300ejb.433.1592968345467; Tue, 23 Jun 2020 20:12:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592968345; cv=none; d=google.com; s=arc-20160816; b=l6nLc8B+rPjIklzulk7e+tdW20APr1h/gVjr9W4W9grGXz16fR8LXNrM93FbvNOF25 nNT+A9k6wI25w7tsIKGwVLpR8N0DxXaI+ImumuDgYE9mCido6R7qx9U8wozJvgNVpONo eZdNzFM+zoMACp93IJJcpViDqY7iH4qGMgX5rjNq9z2VdAeOoCmf37c8D9D2hDAO1FHZ SKod+0g/cpBIkHRfxuT3VfbV91t/nwEfBl4YS4qv3nNP/vNg8JuX2BJz+gFahu30kbtq sxEwicAn5GLSagNjlpVXBSdMXhFNzaCpDp+EpQt/ILonn/C2+oKipwdz7yij9klIimGb fLlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ZsWu8ZUl1jE3k6DJkKHds2eB9NM/YRkkX3/ygvqR5AE=; b=CovI9TNP6PNAxPh3ipx/gbYdC35nmZF4piwkS8EIks6gZxHhjN+dpMXdw0oUpFv7S+ m3nWXMBxKxpbMSye+V8/slbwj6gZphqLALQy77+ZHhovcpFzIxrXCtZqesAJpoafes/9 bGQcrv4YuNiZ2ea/9lfvLo4QBbYepxIAiSugatsv6hYegC/tdqUZ7Eehm+u3Cx5wmVk7 Bobw7iC6c4rqtNvM3vqHr8iCF5wfkjrbti0M6BWOkb4bFe8qoCgbKxNT9cuJZCPy3VZX 6URKK2ukzdBGOF9Vh5DKgjk+0+hsyCwkwEf8pcjL0XaDTakZKBnwSsrvNLcgI+aD6yZF FHvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PU7bqkTK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oh22si11022395ejb.667.2020.06.23.20.12.01; Tue, 23 Jun 2020 20:12:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PU7bqkTK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388611AbgFXDI1 (ORCPT + 99 others); Tue, 23 Jun 2020 23:08:27 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:30984 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388356AbgFXDI0 (ORCPT ); Tue, 23 Jun 2020 23:08:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592968106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZsWu8ZUl1jE3k6DJkKHds2eB9NM/YRkkX3/ygvqR5AE=; b=PU7bqkTKTBeVnGVSy2I0PYfBIrSN/3OSFoQtrJbX/B0GijcP0sHeaqYoEVm9DlNDOlJnJ5 BG0XITGxFK/hJWxvA9kUgaJsMwKTc3KDqc6St7kklIskAZCq6/sJyZNIMZeFbVGHUitIZh yFlBnNBJZSGO8xpPw3mYSeq+OGMDEWg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-294-gIuNpAsLNoSQXCKeSxl5rQ-1; Tue, 23 Jun 2020 23:08:24 -0400 X-MC-Unique: gIuNpAsLNoSQXCKeSxl5rQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3F66C18585A1; Wed, 24 Jun 2020 03:08:22 +0000 (UTC) Received: from treble (ovpn-113-107.rdu2.redhat.com [10.10.113.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 214CB1A836; Wed, 24 Jun 2020 03:08:20 +0000 (UTC) Date: Tue, 23 Jun 2020 22:08:18 -0500 From: Josh Poimboeuf To: Kristen Carlson Accardi Cc: keescook@chromium.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, Peter Zijlstra , arjan@linux.intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, rick.p.edgecombe@intel.com Subject: Re: [PATCH v3 01/10] objtool: Do not assume order of parent/child functions Message-ID: <20200624030818.bvv3kld63sguqxxm@treble> References: <20200623172327.5701-1-kristen@linux.intel.com> <20200623172327.5701-2-kristen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200623172327.5701-2-kristen@linux.intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 23, 2020 at 10:23:18AM -0700, Kristen Carlson Accardi wrote: > If a .cold function is examined prior to it's parent, the link > to the parent/child function can be overwritten when the parent > is examined. Only update pfunc and cfunc if they were previously > nil to prevent this from happening. > > Signed-off-by: Kristen Carlson Accardi > Acked-by: Josh Poimboeuf FYI, this patch is now in the tip tree. -- Josh