Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp225300ybt; Tue, 23 Jun 2020 20:19:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJCMejbjR1o3TboefmMR48Tpv2ejzY2StUKQaBjUk2wNMO2QwXzwFJ2+5UP98zzxHqTgIt X-Received: by 2002:a17:906:fb9b:: with SMTP id lr27mr22281604ejb.405.1592968773279; Tue, 23 Jun 2020 20:19:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592968773; cv=none; d=google.com; s=arc-20160816; b=IUzUis9BUXbwAnC3YLH+FJuZ2DsDBiN4wGYR3gdOnYR8OJja5udrT6F4cBGCnrtK8x EVmfeK30lVqGAqKd39lCF6xQYdjbkKFT24cQUaxJJambMqybJEcYnfbjjW6GACWzdDaj +OPV/bMi4chpGH7kmAj3t5Ef+JkyLmqNMoMm0AwdGpNT9BuNc2xZs/bGdURyG0ei2SBX STVVdbJrP1oPLXzCpduO9nZLnxMFluqDPZwS6l3oXg9WIm0JJHgjA9W/VCMPWGu44Ybe 0lk9zXD8P16dHDI51HVdqV/WEf9nl3No4XSMIehocAkDPVdU8tzMTFh+vl7T8BcxtJO9 Pl1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=HzcTZK8ZMHcUosCF5MoFGBllMR8mCwQPVACAvhNQLG0=; b=wQOdpfj6RhSs/1dbb999vnY7gq9zFausFtb2mv58Ez8vaSee1R1P8wMMq/Qd9bMwT+ fjhSxX2yOyYKvYJCgO2TWG0/TYxpbKGTnyQOaeMC750PbPSj2V4bxwyb4JgBf2ygPkFL AtTL87h+wY/dbM4EwvOLW492xSbJk0hcFD+URoO/tHj8UIUkU8cjnESSP77mfAdtv9ei P/rDo20S10Hn2sPxqtzj9ymzI+NIGbN6Yd/7ASRNAjlO0cpHAqHafngkYG2XYPjWmUf3 24/ElySRXco0gYbN5Q5A7aOaxtHOuZIwWQkDF8BKKq40oQlU77UXrbB37Dpyk5gNav+A Z9uw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id op10si6242909ejb.149.2020.06.23.20.19.09; Tue, 23 Jun 2020 20:19:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388526AbgFXDSx (ORCPT + 99 others); Tue, 23 Jun 2020 23:18:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387985AbgFXDSw (ORCPT ); Tue, 23 Jun 2020 23:18:52 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7150CC061573; Tue, 23 Jun 2020 20:18:52 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CDE9C129835C8; Tue, 23 Jun 2020 20:18:51 -0700 (PDT) Date: Tue, 23 Jun 2020 20:18:50 -0700 (PDT) Message-Id: <20200623.201850.2071234644181824274.davem@davemloft.net> To: gaurav1086@gmail.com Cc: kuba@kernel.org, hkallweit1@gmail.com, mhabets@solarflare.com, mst@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net/ethernet] do_reset: remove dev null check From: David Miller In-Reply-To: <20200624005600.2221-1-gaurav1086@gmail.com> References: <20200624005600.2221-1-gaurav1086@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 23 Jun 2020 20:18:52 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gaurav Singh Date: Tue, 23 Jun 2020 20:55:45 -0400 > dev cannot be NULL here since its already being accessed > before. Remove the redundant null check. > > Signed-off-by: Gaurav Singh I changed your Subject to be: [PATCH net-next] xirc2ps_cs: remove dev null check from do_reset(). Since that is more properly formed. Applied to net-next, thanks.