Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp228023ybt; Tue, 23 Jun 2020 20:25:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuTLNU6ZYFLc+2CQ2cFEwthBChVrvP6FIRfgSIyy/FbFo1HiSnd+BFq9Hcjf9aQuHNuZCT X-Received: by 2002:aa7:d313:: with SMTP id p19mr18412121edq.32.1592969108638; Tue, 23 Jun 2020 20:25:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592969108; cv=none; d=google.com; s=arc-20160816; b=VPm/aq9e9d4VHRGq/DxMbs4TCSrlzNdMYhXXOE3HZsHtX9fUNCvQwXH0KPDZ9ntg85 aZNQVJNYYawQTYB3pfW1K8AmlwooTSRR3PSG1O0wBQrNwgG5+grlML1X4gfZBhkpSQeD T54I3raeMrx5y1s6jBT0iRpf3Njs8gTmLDxLCVYFxjZ4+pUA3oUxsOuRnzQCIQ+OO3Dp fgKfCyEwiwb3KgEZrVFggdl1PSVpu0/SSHMCcsl6WCVQMlCl/nmUARA8x6fgYO1YLvN5 D8nvuWejUffbcG9mAS9Lu4ADVP4TxdnMk/tutiWunsru7w22Tz0jmmEXm69NSoASYHvt XCKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=hEx8uqeBHPxPdV5BllNSU8QWknWZN2+obBCmeWtOcXI=; b=MhvZlmL4ZOdb6XwgNBHMYkIMhYNwlcqwc8wmvLzb5PT0mlEOwuhJfnA6CgaqWuLltc hzADu68YOe/nXYwgGUBwgLYT2CmvfIgRkRULISyip27uxYpnRrW273gaEGBsp0zg2CaX VS5RX08wMRRUCj1jx6SiwFVoFifI3lXj3nRyzt4P/X3LnqjRJto06+a4slN2AtsZHTCY gROmJTWoGQTKy4bqJvHHXbdy5ni0Trfq5WXngYwsva2NFrKva4DgtNCTERHDta5mffrn Y776K8hXHpzwJfaizyr+Asz5xedThkIlhJ01lva1JYTSkXXDg2Emw/x6jkHNxFkT9uC4 iCqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e23si368873edq.600.2020.06.23.20.24.45; Tue, 23 Jun 2020 20:25:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388644AbgFXDYF (ORCPT + 99 others); Tue, 23 Jun 2020 23:24:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387985AbgFXDYE (ORCPT ); Tue, 23 Jun 2020 23:24:04 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD71AC061573; Tue, 23 Jun 2020 20:24:04 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1C128129847C5; Tue, 23 Jun 2020 20:24:04 -0700 (PDT) Date: Tue, 23 Jun 2020 20:24:03 -0700 (PDT) Message-Id: <20200623.202403.1704397333023796145.davem@davemloft.net> To: likaige@loongson.cn Cc: kuba@kernel.org, benve@cisco.com, _govind@gmx.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lixuefeng@loongson.cn, yangtiezhu@loongson.cn Subject: Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint() From: David Miller In-Reply-To: References: <1592899989-22049-1-git-send-email-likaige@loongson.cn> <20200623135007.3105d067@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 23 Jun 2020 20:24:04 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kaige Li Date: Wed, 24 Jun 2020 10:07:16 +0800 > You are right. Should I do spin_unlock before the enic_open, or remove > spin_lock in enic_reset? You need to learn how this driver's locking works and design a correct adjustment.