Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp230593ybt; Tue, 23 Jun 2020 20:30:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/6+5ivdncTrvRZYCkc1ZtZMgkgGVgCbLqaqxJvZl8RhfAnEDh6UrOkuSE35llYkrEybaR X-Received: by 2002:a17:907:35c2:: with SMTP id ap2mr21841972ejc.530.1592969457590; Tue, 23 Jun 2020 20:30:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592969457; cv=none; d=google.com; s=arc-20160816; b=ucbupAH33RXT3Bq0LJbCqQphWi49Lhl5MD8KZzEBZ1xxocd3CpGD9/nM8SR858y+SI XvkPPwxiv3/uKNvpf8+emsNRgcoq9GpyxsNv4j6DFdQ6VJoh9P0e4ZnIORNk3DRUy+6m HcSH6xf+NoPtdGAJ76p8bzxYaIUUDTvoUN4vl1/0istGTZe9TZ0wp9gRGB67vytD1wFL XWAWeN5IZwHSE8XVyW6zAwlP6uh5TrvMzPug6ABR/uvmuUAHyKR5TMpTopUOydcKHVE6 SIy9Y195Iad5hTl0NOXJ1rI77Q9JQv7T2UDjUoA5R5V89OXPdW27JIzElYYhjGRCeUgR A8hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=aya2dmcmp5ST1CF+gcZ6GEE/P2wWVjRvqf/lFPDK1Rc=; b=C8n2tGB1iOyD1bTYSsZO4mq2PEoN6Rw/+DDUmRLhiGTD8d/QQVL9klyhuVlvL38f7u r86Lp3kTng7hviMNfOiv6PLf+1N+aCEkDiyngu76wpiHVtQgtuUH1sm2dzrzq2SuOr4u E6ZQE12GmhlcKUS+jDu8HU/yZ+svGIqagC5btp4OWBtWy4pC+OZGoHB6fO0aoYCsotHw e1updFdcbFjnCCkx23SLAKEL05X8B0rDdutxKC5L3IGjNBgJMWvrq2ZHWDRpzz7zOXXK G+LrvFGnvM3D/U83IJ5QrU96xyRgQFp3sqMF+T7ctpyLk8CY/Xp+QtRBRIyiqf8Tdg1g uvjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y12si1965293edj.487.2020.06.23.20.30.34; Tue, 23 Jun 2020 20:30:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388791AbgFXD1t (ORCPT + 99 others); Tue, 23 Jun 2020 23:27:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387985AbgFXD1s (ORCPT ); Tue, 23 Jun 2020 23:27:48 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6687FC061573; Tue, 23 Jun 2020 20:27:48 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D8E7C1298630D; Tue, 23 Jun 2020 20:27:47 -0700 (PDT) Date: Tue, 23 Jun 2020 20:27:47 -0700 (PDT) Message-Id: <20200623.202747.548424486214848564.davem@davemloft.net> To: gaurav1086@gmail.com Cc: kuba@kernel.org, dsahern@gmail.com, David.Laight@ACULAB.COM, gnault@redhat.com, liuhangbin@gmail.com, linux-decnet-user@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net/decnet] dn_route_rcv: remove redundant dev null check From: David Miller In-Reply-To: <20200623034133.32589-1-gaurav1086@gmail.com> References: <20200623034133.32589-1-gaurav1086@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 23 Jun 2020 20:27:48 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gaurav Singh Date: Mon, 22 Jun 2020 23:41:19 -0400 > dev cannot be NULL here since its already being accessed > before. Remove the redundant null check. > > Signed-off-by: Gaurav Singh Applied.