Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp230708ybt; Tue, 23 Jun 2020 20:31:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyK6cpCTHDfF3+3PARteCR4iPq75t2nmk2tirb9JkoWX548HJF0jYQ6GrhVevL07Qc3c4KO X-Received: by 2002:a17:906:aac1:: with SMTP id kt1mr11286428ejb.408.1592969470920; Tue, 23 Jun 2020 20:31:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592969470; cv=none; d=google.com; s=arc-20160816; b=lzl6E74PuOdA1LcHxisa/4My0Q5pkRf//NT3vjO9YFHZLiwERrvrs4EPuv7E+xgkDu N4LRnoLwmhv+vgvy8fKhkzqYx+Ey8lu6Ad2mmBbXVh76pvJm65Q7YANmn0i2NvujENKZ k/FuOOB9HtaNty2eJp1v2efMey3mk8riZZ9PcwAeZZjTKO//TZ4MHcR+mB5TQ7nxRMqC 9/i+u9f9V0fkXOS+QDKjKCmtg+LBOslaliEWFNRk1McxW7VcgNfI6tFkV3REz7yT5u+c OZj31gXHyiQUnu/OEonouTZqre0UxMm3PC6t5hiaV/FWYGaQQsAjgs8tYWKspjWWCZCT uFxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=ejTIcYc0vw691wRiffYXnopQXlPsd5FoHaynbFIEV7s=; b=dA3+R5GXuuYOl77x/nXLknk0XsrFZu+99g1PdhPOFvznZEE2UNRlHBm9Y7658mCofJ m0upoXil1t3BSmJ13VyvSHJgv2bxW1qB6x7cECOppUnV4z+CS6il4aca/qYF9nnvLxHT 5iUuHbbMz5iiNGY+Ps4zLBMvSNeBKNc7l+mgotM//RnwIWzCAnbyE6BX4iA9M6KK7Vk1 9+P6wUp0aSA9ehhWdGbJgdxPsr6iTA4POovnW9d07u6lQd3sjQV1nbrStncyMNqW11Jh PC56dzQa9NIo8nb23LDTMZ7pjanBcOtvwGYkLHq9s5qpHKdJzg8+2yPI3oerU/yOIMUv 8+FQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lo22si6138226ejb.175.2020.06.23.20.30.43; Tue, 23 Jun 2020 20:31:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388770AbgFXD1l (ORCPT + 99 others); Tue, 23 Jun 2020 23:27:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387985AbgFXD1l (ORCPT ); Tue, 23 Jun 2020 23:27:41 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FEE9C061573; Tue, 23 Jun 2020 20:27:41 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5BC6C1298630D; Tue, 23 Jun 2020 20:27:41 -0700 (PDT) Date: Tue, 23 Jun 2020 20:27:40 -0700 (PDT) Message-Id: <20200623.202740.2271941543708082998.davem@davemloft.net> To: gaurav1086@gmail.com Cc: kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net] dcb_doit: remove redundant skb check From: David Miller In-Reply-To: <20200623025057.20348-1-gaurav1086@gmail.com> References: <20200621165657.9814-1-gaurav1086@gmail.com> <20200623025057.20348-1-gaurav1086@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 23 Jun 2020 20:27:41 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gaurav Singh Date: Mon, 22 Jun 2020 22:50:39 -0400 > skb cannot be NULL here since its already being accessed > before: sock_net(skb->sk). Remove the redundant null check. > > Signed-off-by: Gaurav Singh Applied.