Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp231190ybt; Tue, 23 Jun 2020 20:32:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzN7HMNVC+0EhuSFhjPuAk0zIPUxSUg/GPZBEQ9NNWuJFKMWJ5UBVtsSEeaPzR9uZbIYm8t X-Received: by 2002:a17:906:d204:: with SMTP id w4mr23309827ejz.117.1592969534616; Tue, 23 Jun 2020 20:32:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592969534; cv=none; d=google.com; s=arc-20160816; b=GIxQcvK/Rno0IoVR/Cayg9kymM3H/DHumnhy652F4+3sMaUrIb8H5Pb/RKFetJO7uR 7D0y0w8Ppy98nfhslWbv5alcpXnjGy8/HDK3NxuKhUmOeg/s3Nxgi4lHylBaPAHnxyLF hcmWlQ81PZf4tRFxIv4jL/CAeMFFD8+ZWDpNEQjTefdEr+dIkuamG4QE64+uVKQje4Mr fGg79+RsGT5uoXCBdiPAV4plsuu2WlK3MHX4cP7POaHWPvHpKn1JuJ+q9aBmEzN8q6ka 4b9hmqc8piD/VLZPj/JS4kAtvUYWHXZhydTm/7vAX/LMmgRmHixfdnYJIXv3OCEx0+R2 jx+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=d7/qru8CfUVUg+8jWMA1zrsFbqDR29CoIkuPI4uslm8=; b=unFm0pUwndTJl8vsc9vaCGrIsI2miyI5QVjHuj/6p8TyH+iB7tRIqk9BuwKzsMiiyl 1WdAJr3LuVSkJRnok0OFNLJqxBP8P8MK30Uq0ymh1SU8BLlurEZ8LUf+07pGElUwT+kJ b0vMRtJIy+jxcbubtd/mZfZuzAl6XKq1nYc4Ve2yutv5uh+iTBoDIOpmKw59iAJn8Gqt kf+gRzKiqXz4DLbqS1pQ7+wFiitZBsGdTxWp3m8Z6EmbxWP1/v0Dg6nOKgAFwipsdwE4 Cn+S+3hr0+z/Y/IaQoAvzZmLt0I6wdywFv3o/4UmgWYL5n39jEVRdWU1jcY7VGiutl0u aacg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a18si2022774edn.607.2020.06.23.20.31.51; Tue, 23 Jun 2020 20:32:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388612AbgFXDbe (ORCPT + 99 others); Tue, 23 Jun 2020 23:31:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388292AbgFXDbd (ORCPT ); Tue, 23 Jun 2020 23:31:33 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A991C061573; Tue, 23 Jun 2020 20:31:33 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4F58D1298632C; Tue, 23 Jun 2020 20:31:32 -0700 (PDT) Date: Tue, 23 Jun 2020 20:31:31 -0700 (PDT) Message-Id: <20200623.203131.1093463627031337018.davem@davemloft.net> To: vaibhavgupta40@gmail.com Cc: helgaas@kernel.org, bhelgaas@google.com, bjorn@helgaas.com, vaibhav.varodek@gmail.com, kuba@kernel.org, pcnet32@frontier.com, thomas.lendacky@amd.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH v2 0/3] ethernet: amd: Convert to generic power management From: David Miller In-Reply-To: <20200622111400.55956-1-vaibhavgupta40@gmail.com> References: <20200622111400.55956-1-vaibhavgupta40@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 23 Jun 2020 20:31:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vaibhav Gupta Date: Mon, 22 Jun 2020 16:43:57 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management callbacks > from amd ethernet drivers. > > The callbacks performing suspend() and resume() operations are still calling > pci_save_state(), pci_set_power_state(), etc. and handling the power management > themselves, which is not recommended. > > The conversion requires the removal of the those function calls and change the > callback definition accordingly and make use of dev_pm_ops structure. > > All patches are compile-tested only. Series applied, thanks.