Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Felipe Balbi <balbi@kernel.org>
To:     Macpaul Lin <macpaul.lin@mediatek.com>,
        Chunfeng Yun <chunfeng.yun@mediatek.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        =?utf-8?Q?Micha=C5=82_Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>,
        Sergey Organov <sorganov@gmail.com>,
        Fabrice Gasnier <fabrice.gasnier@st.com>,
        linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
        Macpaul Lin <macpaul.lin@mediatek.com>,
        Macpaul Lin <macpaul.lin@gmail.com>
Subject: Re: [PATCH 1/2] usb: gadget: introduce flag for large request
In-Reply-To: <1592310884-4307-1-git-send-email-macpaul.lin@mediatek.com>
References: <1592310884-4307-1-git-send-email-macpaul.lin@mediatek.com>
Date:   Wed, 24 Jun 2020 09:47:28 +0300
Message-ID: <87wo3xvu2n.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Macpaul Lin <macpaul.lin@mediatek.com> writes:
> Some USB hardware like DMA engine can help to process (split) the data
> of each URB request into small packets. For example, the max packet size
> of high speed is 512 bytes. These kinds of hardware can help to split
> the continue Tx/Rx data requests into packets just at the max packet
> size during transmission. Hence upper layer software can reduce some
> effort for queueing many requests back and forth for larger data.
>
> Here we introduce "can_exceed_maxp" flag in gadget when these kinds of
> hardware is ready to support these operations.
>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
>  drivers/usb/mtu3/mtu3_qmu.c |   11 ++++++++++-
>  include/linux/usb/gadget.h  |    1 +
>  2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/mtu3/mtu3_qmu.c b/drivers/usb/mtu3/mtu3_qmu.c
> index 3f414f9..2b51a20 100644
> --- a/drivers/usb/mtu3/mtu3_qmu.c
> +++ b/drivers/usb/mtu3/mtu3_qmu.c
> @@ -620,7 +620,7 @@ irqreturn_t mtu3_qmu_isr(struct mtu3 *mtu)
>=20=20
>  int mtu3_qmu_init(struct mtu3 *mtu)
>  {
> -
> +	int i;
>  	compiletime_assert(QMU_GPD_SIZE =3D=3D 16, "QMU_GPD size SHOULD be 16B"=
);
>=20=20
>  	mtu->qmu_gpd_pool =3D dma_pool_create("QMU_GPD", mtu->dev,
> @@ -629,10 +629,19 @@ int mtu3_qmu_init(struct mtu3 *mtu)
>  	if (!mtu->qmu_gpd_pool)
>  		return -ENOMEM;
>=20=20
> +	/* Let gadget know we can process request larger than max packet */
> +	for (i =3D 1; i < mtu->num_eps; i++)
> +		mtu->ep_array[i].ep.can_exceed_maxp =3D 1;
> +
>  	return 0;
>  }
>=20=20
>  void mtu3_qmu_exit(struct mtu3 *mtu)
>  {
> +	int i;
>  	dma_pool_destroy(mtu->qmu_gpd_pool);
> +
> +	/* Disable large request support */
> +	for (i =3D 1; i < mtu->num_eps; i++)
> +		mtu->ep_array[i].ep.can_exceed_maxp =3D 0;
>  }
> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> index 6a17817..60e0645 100644
> --- a/include/linux/usb/gadget.h
> +++ b/include/linux/usb/gadget.h
> @@ -236,6 +236,7 @@ struct usb_ep {
>  	unsigned		max_streams:16;
>  	unsigned		mult:2;
>  	unsigned		maxburst:5;
> +	unsigned		can_exceed_maxp:1;

every driver does this without this flag. This is unnecessary.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl7y9wAACgkQzL64meEa
mQZAMhAAgft5sx0Sthuj5ty6Jk7/YrHHMQzKjG9kRLJYN7ne2V/6mGSZT1DIWcNg
DGPpshkW1TLseVRF44HeK8ly5jVezzkV12zyshXaEap8j0/HuLnxoAfOCR+ZoWe7
NkK38xqJkLteRffaSNN8PMfBKQf0uUccPyzOFnCzAq9VlZmFqAUOB5YOXwHlU6J2
caK4tzOihkTHF4WjfHyZ/ObZm/KBgp/qvvJyzW9BB7aHMcoYHPwU/WT7c0Jdamwu
Oryq/BoKsbmghTGuvDHTFkXJPBIKrvcQ5GOVmi5NJX3Xf2gHoesOlM3AehMwMJCC
IeJn0tBF/HxJynii+0jPDETwbfxFH/zMlx4YPjojcRqyK6SXrhBR9b/RBbNRIJPX
1ZnhOMrHOp6JPvQGvSjhc0MmQEzdU0sKgVXAGUGYqyesbtuRAOz+TDPInSZGlR/e
6ZClDpIv9n1qQbAZv9MPtDoHPjCsJKxh4/Bir3FBnCE9Vset4iu3BDCYzldNAgZu
Ci7Nc1UdDLARRTWfbXMeuFHoP9Rz9StGkXPUQirSmx/ZABtQyz6QulqaH2eWEPQ0
orEi3ksZzENyqKPh+pLTuP96xhGWC9wF+OCtWV0MGBknkulc9BZY5754sDtEGLmN
ee8yYb5TbczXGLBnpLxQzCbSWE71D0Xbe8/k0fiwC2zSJmx8wj8=
=gGQs
-----END PGP SIGNATURE-----
--=-=-=--