Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp336184ybt; Wed, 24 Jun 2020 00:02:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwS+oHPkRnSCdHB1doEySUhBrpWJrVBb2yQx2uNJJu+GGaoYDNTftl5oILDzix6w1XMzg2F X-Received: by 2002:a17:906:53d4:: with SMTP id p20mr10977999ejo.472.1592982123524; Wed, 24 Jun 2020 00:02:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592982123; cv=none; d=google.com; s=arc-20160816; b=CQ1+1yw8aEQ/Y+TixgJxImiKXuXLcQnhLD6yBhzwHvto1YghUcUBTtAAmnRhGfrvUo J9wxteeMUru3Y9F7WeSSIkmLyeX7cy6XluutateSXzsLJVkLA+QTNdxpmfVN8K51891P dUeT7vjRNw9P751W5MuPoNaX8sUCWLyGqJhyE7q9yRp+XKv6X7kTby9VRPoPxVtKc0/8 mAZJefoYkfGoy2bHoZB+y4NDwZtF+vPwy11mpVcljV9i6KUn9Sg1cP5GW6Kr4OAksN0u 85vRqKun1RAYwWACaz/DoFzhvV74LYpiqQvs1HGqstQxgV+4SGUDFmQaiQrSjk9svXgs s3WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ruvQqmMaUf10Yjz5Ud3eV7xO8llKqJ4H6Ky4iuYmiEs=; b=b7qkj1o/FkSmj/cxLwwTbBfylLbc1lK0cZN5Gw5r4qG7K7/6+yiTQ/TEP+7+MWuY7K AQk8t4G+FhvPqEWaASEf2chsP9Die6OqRLZ7uECWzFcDyFyHlB0brrcmgknNNF7tXOn7 7n1seOvtDmaLqvloegkDnLU4Fay4QRUzMLQIDbEYCuH2H03/9n4AzJAspm4bF3Agpi+i LUJAoY5nD4fYwrnummIWy4PzR+R9LtLaoYyWoqOqzZDLnR9Gnd3WNZfDTbhpqLyS5jqB CvGEeM71FR/uhGg8Udn8QatE04gUnKV00lUxEe93957lo0HTL20vo/8bsH/KXrIZlVjk MclQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p8si1215933ejf.634.2020.06.24.00.01.39; Wed, 24 Jun 2020 00:02:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389547AbgFXHA7 (ORCPT + 99 others); Wed, 24 Jun 2020 03:00:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388370AbgFXHA7 (ORCPT ); Wed, 24 Jun 2020 03:00:59 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8C77C061755 for ; Wed, 24 Jun 2020 00:00:58 -0700 (PDT) Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnzOr-0006Wh-8u; Wed, 24 Jun 2020 09:00:49 +0200 Received: from sha by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jnzOq-0002xN-GZ; Wed, 24 Jun 2020 09:00:48 +0200 From: Sascha Hauer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , kernel@pengutronix.de, Russell King , Sascha Hauer Subject: [PATCH 1/2] net: ethernet: mvneta: Do not error out in non serdes modes Date: Wed, 24 Jun 2020 09:00:44 +0200 Message-Id: <20200624070045.8878-1-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In mvneta_config_interface() the RGMII modes are catched by the default case which is an error return. The RGMII modes are valid modes for the driver, so instead of returning an error add a break statement to return successfully. This avoids this warning for non comphy SoCs which use RGMII, like SolidRun Clearfog: WARNING: CPU: 0 PID: 268 at drivers/net/ethernet/marvell/mvneta.c:3512 mvneta_start_dev+0x220/0x23c Signed-off-by: Sascha Hauer --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index af60001728481..c4552f868157c 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -3571,7 +3571,7 @@ static int mvneta_config_interface(struct mvneta_port *pp, MVNETA_HSGMII_SERDES_PROTO); break; default: - return -EINVAL; + break; } } -- 2.27.0