Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp379431ybt; Wed, 24 Jun 2020 01:20:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz85goI6kZFaSQDBwvq3ZKCDNEaoiZ2VwIXcmrnS7LEdfPxZDvIz5dQl9WBUHdZwzlxrtJe X-Received: by 2002:a17:907:724d:: with SMTP id ds13mr1838313ejc.73.1592986833553; Wed, 24 Jun 2020 01:20:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592986833; cv=none; d=google.com; s=arc-20160816; b=nulAtWzPGniV/v6fPM+Pxz+SgLN7NmWldtnRoUobmBR6vZVBHfo2m5cQphGHmoAy7T NV5gtfh49r/DUsxcXuofUns3Q83obuIjISYdjIC2+IuoEq+L9Zp+I/ciIpePSWOw0hlD wc2F4K4Sf6jIBIdeIMfkf3I1diOrGA5TWkvZn+npeCC3UFFFxkpIOjWaOUK9EOnpEeah i5s710l3kHAIfllOOySGOFDxdOvEMxyeOXgHg3kgJkwQHCb9BTkNgCN8IfiHaopMAVGj PwQEy7klSDRVGmyvcblQy1fQVimsDoQHAfzxUwzDaO2aeN0CTH6kca6eUBaDhjiWxbZD ko4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=zCorprUuYrnnRrBtOm+/HCwhqE0LHnB9yA0RCKtGnF0=; b=LyXnOAokBSBD4gvT0ffX0x/YIzKv/QzlRzVChOrSGZsc6nsOA4tD1cSVr/8A8wriWJ UuMey4VccuJviM1nMZL965EgDzQSabMP+1GWVflMNGScn0OR8k+oRGKdQClDo65yfUMY NXV98au9h+Y5JFoNI9xuEJ1tuahnLDlmU7PBZyRUOlmERPDNI8DFx5thcoqtrODA2iyn pnGuEflzg96VOMiU157xhP6B+cuVoMqRCsx5DDZ6mv7/fctZwlLcQzQ51gc3HqRX10vo KjtMX2jsp/2d06yWExcJfMGLQqcatzvFsPjwgTR0VS3D4RdBUQP+MspBmWMrOpej1ExC XG/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LxtM6dbY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lu24si5846063ejb.477.2020.06.24.01.20.10; Wed, 24 Jun 2020 01:20:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LxtM6dbY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390323AbgFXITg (ORCPT + 99 others); Wed, 24 Jun 2020 04:19:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:39314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388296AbgFXITf (ORCPT ); Wed, 24 Jun 2020 04:19:35 -0400 Received: from localhost (unknown [171.61.66.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C9982082F; Wed, 24 Jun 2020 08:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592986774; bh=fgExhjyrAR43tXlRTdI8WWUCluEJes8lAjTFdOgFp4k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LxtM6dbYSDQRM+QVzBP+DtFg54XGuBddaQfotfsLmUwsFBddn9lvxwBc1myBWsHhp y1ZpueIOm0Qaf8SQjykmjIMSVc4K2RehGwVwWYrrI+fFS+rDcU/NJvVWkg/av/Ow1d rffA+NB4C05F+x/zJCrKohwnzJTywKbJSxWpUt40= Date: Wed, 24 Jun 2020 13:49:29 +0530 From: Vinod Koul To: Sugar Zhang Cc: Heiko Stuebner , linux-rockchip@lists.infradead.org, Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/13] dmaengine: pl330: Add quirk 'arm,pl330-periph-burst' Message-ID: <20200624081929.GU2324254@vkoul-mobl> References: <1591665267-37713-1-git-send-email-sugar.zhang@rock-chips.com> <1591665267-37713-3-git-send-email-sugar.zhang@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1591665267-37713-3-git-send-email-sugar.zhang@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09-06-20, 09:14, Sugar Zhang wrote: > This patch adds the qurik to use busrt transfers only s/busrt/burst > for pl330 controller, even for request with a length of 1. > > Although, the correct way should be: if the peripheral request > length is 1, the peripheral should use SINGLE request, and then > notify the dmac using SINGLE mode by src/dst_maxburst with 1. > > For example, on the Rockchip SoCs, all the peripherals can use > SINGLE or BURST request by setting GRF registers. it is possible > that if these peripheral drivers are used only for Rockchip SoCs. > Unfortunately, it's not, such as dw uart, which is used so widely, > and we can't set src/dst_maxburst according to the SoCs' specific > to compatible with all the other SoCs. > > So, for convenience, all the peripherals are set as BURST request > by default on the Rockchip SoCs. even for request with a length of 1. > the current pl330 driver will perform SINGLE transfer if the client's > maxburst is 1, which still should be working according to chapter 2.6.6 > of datasheet which describe how DMAC performs SINGLE transfers for > a BURST request. unfortunately, it's broken on the Rockchip SoCs, s/unfortunately/Unfortunately > which support only matching transfers, such as BURST transfer for > BURST request, SINGLE transfer for SINGLE request. > > Finaly, we add the quirk to specify pl330 to use burst transfers only. s/Finaly/Finally Below looks fine, pls reorder the series and have binding patch come first and then the use of binding. Below looks fine though -- ~Vinod