Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp459644ybt; Wed, 24 Jun 2020 03:33:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzpVFo0mbFYHEVAmOhGZnW6KT94guYuqBu9hLxgmH5GILrigUoIMf2pcV40jAPZLI4pJiK X-Received: by 2002:a17:906:e001:: with SMTP id cu1mr8125469ejb.309.1592994823629; Wed, 24 Jun 2020 03:33:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592994823; cv=none; d=google.com; s=arc-20160816; b=G6G/W8Q/kgwTkNlZpTw6wGAbNiTD4Y+4m7e3cCgH23iuaD6MMPEBrLilTwAXu8b65j F+6t56W9BxGsHt0mTvVxpQpYcez1LYSXJRw0UHyEzaVNiXWlBxvzvr+2rM7/be/fQJ9V 4mr5NuIsfmVTjIeX5ptK0NlmuyI/dGBKZ6NnouAANRsql6UjefBaLI848AXJdyJ3tg/M CQDFXwVZybwHyWvstD6qAf14qLebON03Mru4agxarHlDHRlfQeLrAgRsmi+G36N0Okbd W7l/jKawBlmBCyRpxFPEoBAl3M5CxD2dq5LSS5KR/NGxRXZFayoPhxNk1yMydeoWr19b dMRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date; bh=+EN2c3d/8Lvtt5k89C1ro3q9LZqFRK8kHSNtEYwuzuU=; b=jQcgvBiaZYU4aYAtDLAzOSKlUUqN+qfqyvBNKVI/SjfBzZqUwJro14Nmuxv52KJ6/r 4BBo2AEZQXFTHVMxIzuBc0wVFvsqpYphKJplDvlTLUiOTaYwrzifXkQB0WZMO02UPSCF bug2ioF178XiolvV7mhzjMzdbGPxCIbotqWVFYt0xRaNqa+01CneFBZkXxcZ2Z5jbHf1 4LXCcpAe5LdRcbUo6xc7Z3lefRWPclV+YdzZagEsOOPMX6GDLYW4Le5HFzhd5fNopfMA r+RFFENk8XUQuqkAYkxjh6KET7xHr6wRdBKdfvzh0oOgg7NJUBufb12YTYh3hY9LFRjR u90A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k26si11995758ejv.109.2020.06.24.03.33.20; Wed, 24 Jun 2020 03:33:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390389AbgFXK3o (ORCPT + 99 others); Wed, 24 Jun 2020 06:29:44 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:59142 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388377AbgFXK3n (ORCPT ); Wed, 24 Jun 2020 06:29:43 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05OA3Xe3086323; Wed, 24 Jun 2020 06:29:28 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 31uwyrv06c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Jun 2020 06:29:28 -0400 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 05OAS12d040149; Wed, 24 Jun 2020 06:29:28 -0400 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com with ESMTP id 31uwyrv05m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Jun 2020 06:29:28 -0400 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 05OAKPvX032124; Wed, 24 Jun 2020 10:29:26 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma02wdc.us.ibm.com with ESMTP id 31uus3k5h1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Jun 2020 10:29:26 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 05OATQaw54395248 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Jun 2020 10:29:26 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5F242112066; Wed, 24 Jun 2020 10:29:26 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1186E112062; Wed, 24 Jun 2020 10:29:26 +0000 (GMT) Received: from sofia.ibm.com (unknown [9.85.91.248]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 24 Jun 2020 10:29:26 +0000 (GMT) Received: by sofia.ibm.com (Postfix, from userid 1000) id 2227A2E4AAE; Wed, 24 Jun 2020 15:59:21 +0530 (IST) Date: Wed, 24 Jun 2020 15:59:21 +0530 From: Gautham R Shenoy To: Srikar Dronamraju Cc: Andrew Morton , linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Mel Gorman , Vlastimil Babka , "Kirill A. Shutemov" , Christopher Lameter , Michael Ellerman , Linus Torvalds , Gautham R Shenoy , Satheesh Rajendran , David Hildenbrand Subject: Re: [PATCH v5 2/3] powerpc/numa: Prefer node id queried from vphn Message-ID: <20200624102920.GB31972@in.ibm.com> Reply-To: ego@linux.vnet.ibm.com References: <20200624092846.9194-1-srikar@linux.vnet.ibm.com> <20200624092846.9194-3-srikar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624092846.9194-3-srikar@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-24_05:2020-06-24,2020-06-24 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 cotscore=-2147483648 mlxscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 impostorscore=0 bulkscore=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006240070 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Srikar, On Wed, Jun 24, 2020 at 02:58:45PM +0530, Srikar Dronamraju wrote: > Node id queried from the static device tree may not > be correct. For example: it may always show 0 on a shared processor. > Hence prefer the node id queried from vphn and fallback on the device tree > based node id if vphn query fails. > > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Cc: Michal Hocko > Cc: Mel Gorman > Cc: Vlastimil Babka > Cc: "Kirill A. Shutemov" > Cc: Christopher Lameter > Cc: Michael Ellerman > Cc: Andrew Morton > Cc: Linus Torvalds > Cc: Gautham R Shenoy > Cc: Satheesh Rajendran > Cc: David Hildenbrand > Signed-off-by: Srikar Dronamraju This patch looks good to me. Reviewed-by: Gautham R. Shenoy -- Thanks and Regards gautham.