Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 00/11] media: exynos4-is: Improve support for s5pv210 and
 parallel ports
To:     Jonathan Bakker <xc-racer2@live.ca>, kyungmin.park@samsung.com,
        s.nawrocki@samsung.com, mchehab@kernel.org, kgene@kernel.org,
        krzk@kernel.org, linux-media@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Tomasz Figa <tfiga@chromium.org>
References: <BN6PR04MB06602E7221CC7455F3142540A3AE0@BN6PR04MB0660.namprd04.prod.outlook.com>
From:   Hans Verkuil <hverkuil@xs4all.nl>
Message-ID: <07fb9000-ae00-efcd-e91a-48765ff3d4bf@xs4all.nl>
Date:   Wed, 24 Jun 2020 13:39:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <BN6PR04MB06602E7221CC7455F3142540A3AE0@BN6PR04MB0660.namprd04.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Can someone from Samsung or someone who knows this SoC take a look at this series?

This series looks sane to me, so I'll probably merge this if nobody replies
in the next two weeks or so.

Regards,

	Hans

On 26/04/2020 04:26, Jonathan Bakker wrote:
> This patchset improves support in the exynos4-is driver for s5pv210
> platforms as well as for sensors connected to the parallel ports
> and not using the CSIS device.
> 
> Fixes range from nullptr exceptions to probe fixes to JPEG fixes.
> 
> Notably, it also changes the fwnode probing of parallel port sensors
> to match the binding doc.  The binding doc said port A = reg 0 and
> port B = reg 1 but the driver implemented A=1 and B=2.  The only in-tree
> user of parallel ports is currently Goni, which notes that it uses port
> A but has reg = 1.  Also note that the sensor driver is not mainlined
> despite being present.  I have left the DTS as-is.
> 
> Some patches cleaning up non-DT support are also included.
> 
> The patches have been tested on a first-gen Galaxy S GT-i900M device based
> on S5PV210.  Two sensors (CE147 and S5KA3DFX, both with non-mainline
> drivers), both attached to port A, were succesfully used.
> 
> Jonathan Bakker (10):
>   media: exynos4-is: Remove static driver data for S5PV210 FIMC variants
>   media: exynos4-is: Fix nullptr when no CSIS device present
>   media: exynos4-is: Correct missing entity function initialization
>   media: exynos4-is: Improve support for sensors with multiple pads
>   media: exynos4-is: Properly set JPEG options when not using CSIS
>   media: exynos4-is: Add support for multiple sensors on one port
>   media: exynos4-is: Remove inh_sensor_ctrls
>   media: exynos4-is: Remove unused struct member input_index
>   media: exynos4-is: Prevent duplicate call to media_pipeline_stop
>   media: exynos4-is: Correct parallel port probing
> 
> Tomasz Figa (1):
>   media: exynos4-is: Request syscon only if ISP writeback is present
> 
>  .../media/platform/exynos4-is/fimc-capture.c  | 22 ++----
>  drivers/media/platform/exynos4-is/fimc-core.c | 67 ++----------------
>  drivers/media/platform/exynos4-is/fimc-core.h |  5 --
>  drivers/media/platform/exynos4-is/fimc-reg.c  |  7 ++
>  drivers/media/platform/exynos4-is/media-dev.c | 68 ++++++++++++++-----
>  drivers/media/platform/exynos4-is/media-dev.h |  1 +
>  include/media/drv-intf/exynos-fimc.h          |  2 +-
>  7 files changed, 72 insertions(+), 100 deletions(-)
>