Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp504856ybt; Wed, 24 Jun 2020 04:44:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvGFb6llfOM/xM5mmTa5eWsJqc2gy/eUAsUnbDCociNZy/WQBphOYOlFORL/WXoUrVNYhS X-Received: by 2002:a17:906:950c:: with SMTP id u12mr14722317ejx.37.1592999057445; Wed, 24 Jun 2020 04:44:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592999057; cv=none; d=google.com; s=arc-20160816; b=IYzJA/PDef9m9SObYJl66cks09dYK+Qu0uyB/VPHN+mzdG2T8Bn1L2XrY4N/vVsmFN ntVgF6OhrkT14Dk7Akcdt2voIx26OWLBuHRWKHt7P2PVD8Muq4QbczUbQPfdsscwG945 daQTP2Efcou3C5g7Gu8S2fIMfTieCyaIWyFJYavf4T0VSG4/ftzorvfqx8ztfgiW5BPF U3/guvgIVPsjzZ1L2oS3pWjk6J8I9OMqOf2DOv9d83oDGOVQzXxVNB1EfmQZeGnkoe62 wXdUW6saTWDozifEkpqAkcI+mMdxtbExT58M8N1NLVQrh4ymIwve4kvv6TdG807DJd9l vMbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :mime-version:dmarc-filter:dkim-signature; bh=9LfcwCs2gMYTXx7sFuykUefGcgaFT5AdWe1eKC67wtM=; b=C0jcF1OSx5Kb9by5WAU8JEXiB2q6TJqX6LFW/eYmcVyM1qhoifxL0a5drEfW/pdIbG ZHcuYT1FhFgL6Qp+U6f7AB50EZrhePWHip6SudMZjDrijP6gd5WmR0bCCF16icikR6gh PoRQ08KxLzdAZE8m/POzKrjpoHgzJ608l0N+Z9Bq0/uoVpoZB25RrVDXv22yrR/s+yqR cE5YKdLqqzLS3ejdxNMt5I529Y7yJhsmRIE1XQeiZitR38TZRDr6i5qtm11urzqlsV5M rLEJTAyI7VsJiJ63dNtrRTBySkuuokn2pk3wjD/QV04I1a/vwcP5uvr7lPZW820lGu5Z 6RMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=N8tklI08; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d16si12087154ejp.131.2020.06.24.04.43.54; Wed, 24 Jun 2020 04:44:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=N8tklI08; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390727AbgFXLmu (ORCPT + 99 others); Wed, 24 Jun 2020 07:42:50 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:44132 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388360AbgFXLmt (ORCPT ); Wed, 24 Jun 2020 07:42:49 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1592998969; h=Content-Type: Cc: To: Subject: Message-ID: Date: From: MIME-Version: Sender; bh=9LfcwCs2gMYTXx7sFuykUefGcgaFT5AdWe1eKC67wtM=; b=N8tklI082hHeOgdxalypTvS+k4QkWWgEWKjtLd3C2w0qLDVJ2kTH3eR2q806rHkw4VR1JQhn tZ3FToEelapw70zKqNjvnxlrmsM83Pdz9fGDQwwJ0ldXKAzCDsrYLtwUZKv3LdRvlZ74R1AM Zx2E3l/gPdWtMkCKDn0f61raPIQ= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n20.prod.us-east-1.postgun.com with SMTP id 5ef33c37a6e154319ff49876 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 24 Jun 2020 11:42:47 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 0602BC433CA; Wed, 24 Jun 2020 11:42:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=ham autolearn_force=no version=3.4.0 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: pkondeti) by smtp.codeaurora.org (Postfix) with ESMTPSA id 82E97C433C6 for ; Wed, 24 Jun 2020 11:42:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 82E97C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=pkondeti@codeaurora.org Received: by mail-ej1-f43.google.com with SMTP id dr13so2139698ejc.3 for ; Wed, 24 Jun 2020 04:42:46 -0700 (PDT) X-Gm-Message-State: AOAM5301WBr+IiY/+rJ5EEHYcG7TN0xuIBhbIRl6PpQZemRpkdvVxd5k yAh9ixq86JT97RDClTYN3+MgA7W9XNqPmve+nSk= X-Received: by 2002:a17:906:8401:: with SMTP id n1mr24116691ejx.479.1592998965202; Wed, 24 Jun 2020 04:42:45 -0700 (PDT) MIME-Version: 1.0 From: Pavan Kondeti Date: Wed, 24 Jun 2020 17:12:33 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Looping more in detach_tasks() when RT and CFS tasks are present To: Vincent Guittot , Peter Zijlstra Cc: LKML , leiwen@marvell.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vincent/Peter, in load_balance(), we derive env->loop_max based on rq->nr_running. When the busiest rq has both RT and CFS tasks, we do more loops in detach_tasks(). Is there any reason for not using rq->cfs.h_nr_running? Lei Wen attempted to fix this before. https://lore.kernel.org/lkml/1376814322-7320-2-git-send-email-leiwen@marvell.com/ Thanks, Pavan -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project