Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 24 Jun 2020 13:26:16 +0100
From:   Qais Yousef <qais.yousef@arm.com>
To:     Vincent Guittot <vincent.guittot@linaro.org>
Cc:     Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Patrick Bellasi <patrick.bellasi@matbug.net>,
        Chris Redpath <chris.redpath@arm.com>,
        Lukasz Luba <lukasz.luba@arm.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] sched: Optionally skip uclamp logic in fast path
Message-ID: <20200624122616.jw7wqnvzfp3hw4lm@e107158-lin.cambridge.arm.com>
References: <20200619172011.5810-1-qais.yousef@arm.com>
 <6c1a6003-8f51-dadc-53e4-a2fa034dbe36@arm.com>
 <CAKfTPtDh+D9AdzcsjYuv8LmtWag2MaHx7Ysrxb7JQittKa_K0A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAKfTPtDh+D9AdzcsjYuv8LmtWag2MaHx7Ysrxb7JQittKa_K0A@mail.gmail.com>
User-Agent: NeoMutt/20171215
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 06/24/20 11:00, Vincent Guittot wrote:
> On Tue, 23 Jun 2020 at 19:40, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:

[...]

> > (4)
> >
> > CPU0:  Function             Hit    Time            Avg             s^2
> >        --------             ---    ----            ---             ---
> >        deactivate_task  1998246    2428121 us      *1.215* us      0.062 us
> >        activate_task    1998252    2132141 us      *1.067* us      0.020 us
> >
> > CPU1:  Function             Hit    Time            Avg             s^2
> >        --------             ---    ----            ---             ---
> >        deactivate_task  1996154    2414194 us      1.209 us        0.060 us
> >        activate_task    1996148    2140667 us      1.072 us        0.021 us
> 
> I have rerun the tests that I ran previously on my octo core arm64 (hikey):
> 20 iteration of perf bench sched pipe -T -l 50000
> tip stands for tip/sched/core
> uclamp enabled means both uclamp task and uclamp cgroup
> the stdev is around 0.25% for all tests
> 
>                            root           level 1       level 2       level 3
> 
> tip uclamp disabled        50653          47188         44568         41925
> tip uclamp enabled         48800(-3.66%)  45600(-3.37%) 42822(-3.92%)
> 40257(-3.98%)
> /w patch uclamp disabled   50615(-0.08%)  47198(+0.02%) 44609(+0.09%)
> 41735(-0.45%)
> /w patch uclamp enabled    49661(-1.96%)  46611(-1.22%) 43803(-1.72%)
> 41243(-1.63%)
> 
> Results are better with your patch

Thanks both for testing!

Cheers

--
Qais Yousef