Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Anson Huang <anson.huang@nxp.com>
To:     Franck Lenormand <franck.lenormand@nxp.com>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will@kernel.org" <will@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        Leo Li <leoyang.li@nxp.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "geert+renesas@glider.be" <geert+renesas@glider.be>,
        "olof@lixom.net" <olof@lixom.net>,
        Leonard Crestez <leonard.crestez@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        Peng Fan <peng.fan@nxp.com>, "arnd@arndb.de" <arnd@arndb.de>,
        "krzk@kernel.org" <krzk@kernel.org>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH] firmware: imx: Move i.MX SCU soc driver into SCU firmware
 driver
Thread-Topic: [PATCH] firmware: imx: Move i.MX SCU soc driver into SCU
 firmware driver
Thread-Index: AQHWSiJDQC8EHEvbXEmiUi/qZAMEN6jnsyEAgAAG+IA=
Date:   Wed, 24 Jun 2020 13:15:36 +0000
Message-ID: <DB3PR0402MB391634C85F53E8A9456E89F0F5950@DB3PR0402MB3916.eurprd04.prod.outlook.com>
References: <1593000687-12213-1-git-send-email-Anson.Huang@nxp.com>
 <AM4PR0401MB24016D7F1E97F70AEC23BEB392950@AM4PR0401MB2401.eurprd04.prod.outlook.com>
In-Reply-To: <AM4PR0401MB24016D7F1E97F70AEC23BEB392950@AM4PR0401MB2401.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b1744f7-54ad-4aef-1241-08d81840af21
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2020 13:15:36.6289
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 41hLjJna8yXoME5lmCFf138pkO0WqRKsl6/y5PV1ETjxcVNM1tt3IZIAeM9t3D97bCH+X8yd8G6MUPuZjohuQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5467
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Franck/Arnd

> Subject: RE: [PATCH] firmware: imx: Move i.MX SCU soc driver into SCU
> firmware driver
>=20
> Hello,
>=20
> The move of folder is a good idea however I do not feel adding the code o=
f
> soc-imx-scu.c  to imx-scu.c is the best.
> Until now imx-scu.c was focused on exchanging the RPC and init the IRQ.
> Why not have soc-imx-scu.c  copied to imx-scu-soc.c (change filename) to
> have a pattern similar to imx-scu-irq? And keep the  imx_scu_soc_init int=
o
> imx-scu.c.
>=20
Sound like making sense to me, it can make the code architecture more clear=
.=20

Hi, Arnd
	What do you think?

Thanks,
Anson