Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp580169ybt; Wed, 24 Jun 2020 06:26:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxh53L6Y7LD7U/XgKprb7mV81ofYJ9X35lb4NOj7I6sNkSUcKyY+fXc8C1wWnFp/LmtGGRh X-Received: by 2002:a17:906:af76:: with SMTP id os22mr23912302ejb.191.1593005206522; Wed, 24 Jun 2020 06:26:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593005206; cv=none; d=google.com; s=arc-20160816; b=MP/06Op/gZEeSv9CCM9fKJ/G2/6tduyGlL+72QkJmxszlMSPa6eWD46WPL/Ll91/H6 rRiRZSK4ORK/qFl2Lmbd6iR5q/u+ExoiZXhimZu9JG++UpukZ9tZfovorZlL7aKIbJBX cTuRcxWATyUUnPe3us/sAtT+vNsC7QMQtIL8X6F6hmUYnn9VG2H+NcqhMDlg0Z/+dzqk z4YhkVhirSNC3cKZldXnhAVsWPZoKQoNVkhzpshvE9HNIoElZzRnB8ThmguxTyl6XCH2 kGrLSi0KzWh3V9IOUPddoBHN+iChrSARvuSJcDAKNiAkgdAiIQzfnMuNVHTaWWFFAACN jpsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+TiU9ss+3ZgWOu77K8X0POd9ca9k3sXB27qxKlhlZfI=; b=HJ7+bXiwHN1qBmU9Bu8pMAitc5FzovwojX3jkIRL0gPJSuMB6cPgBBoE/+gnvpVSI4 7J4cBVWbVwpY0ERtyZ/fZgYNlZL4Gzd5zmDlfLjE0wrCU+zn7yTHp10s9DOwkjg8rqQm yRUgNt3AeVrf44bkJnspdSrbMNt28mcIRujmnQynbjmBljAp8GKF8ZVkSD3DWg8cq1F6 827sa70wwIL+goce5HYRxm/mMrv2j5oJjfg5v2wCYjPh9YTEdl+m6NbwZeJO1HwHFoEu ZPceLy8M1MVmDyC+Wg0aKMXLUL1ehXfLF6/k53eIQinuXm0f+hnBzl2owaWyatP2lAv9 N/2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I0ghPOxM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l19si6221329eja.516.2020.06.24.06.26.23; Wed, 24 Jun 2020 06:26:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I0ghPOxM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389957AbgFXNZ5 (ORCPT + 99 others); Wed, 24 Jun 2020 09:25:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:53986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387687AbgFXNZf (ORCPT ); Wed, 24 Jun 2020 09:25:35 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B2EA720738; Wed, 24 Jun 2020 13:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593005135; bh=JmFbJS0PXLoFzco2T3g6Do+UUnsYW2aYLUOdaY8lj+Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I0ghPOxMhm6dri4CB1uByEKsnodv/HbTXGlazQSBuzPHznhC5brjUCLVLAYURDLXq mRTxA2V01ONTgnjLhHWgAZqqulK4hB0upnbtXvRAMWEVVQngyoaecajufaz5tdIN9I YJrOr8x6CBw5QxolcEvBjTCMrqhBA8ziYD7lXAKU= Date: Wed, 24 Jun 2020 14:25:32 +0100 From: Mark Brown To: Andrzej Hajda Cc: Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, andy.shevchenko@gmail.com, Russell King - ARM Linux , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Daniel Vetter , "open list:DRM DRIVERS" Subject: Re: [RESEND PATCH v5 4/5] drm/bridge/sii8620: fix resource acquisition error handling Message-ID: <20200624132532.GC5472@sirena.org.uk> References: <20200624114127.3016-1-a.hajda@samsung.com> <20200624114127.3016-5-a.hajda@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kVXhAStRUZ/+rrGn" Content-Disposition: inline In-Reply-To: <20200624114127.3016-5-a.hajda@samsung.com> X-Cookie: So this is it. We're going to die. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kVXhAStRUZ/+rrGn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 24, 2020 at 01:41:26PM +0200, Andrzej Hajda wrote: > In case of error during resource acquisition driver should print error > message only in case it is not deferred probe, using probe_err helper > solves the issue. Moreover it records defer probe reason for debugging. If we silently ignore all deferred probe errors we make it hard for anyone who is experiencing issues with deferred probe to figure out what they're missing. We should at least be logging problems at debug level so there's something for people to go on without having to hack the kernel source. --kVXhAStRUZ/+rrGn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7zVEwACgkQJNaLcl1U h9Adowf/bt19xA4Q3/G5xTijEYnOc63YWxQGFynpEFvnpuQuTYuDRwL2ybQHpXkD 7dZqUsmE//n9XDWNSi6IHolSzWRtBVqD+LpF/gmGHcqGsPCstcSLeQMVM5b4l5KV x59+x9cTfoYkQ2XoBNZmmWZwGBYqVJvhW+4TysUX+9JCZgxKOG1LXLuMlL7r9qP2 5nI549k1sjQdiC8pevFkysGucfiOGoKIQfcpMqqlIzCFkBCt5pRTYNQ0e4jUh3gT 8qVPKlbm99aJ5+TGjPWtUzndU9VM08psKQNnguznxAbaHhF+ZA11l1AiIPv2qHkn YtM+Bz+sHfeDkTCKefTLds0G3+8Mmg== =oY2K -----END PGP SIGNATURE----- --kVXhAStRUZ/+rrGn--