Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp581592ybt; Wed, 24 Jun 2020 06:28:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5JUU0YrEhJd9C3mciQmEW0Fe5MGv0LSZPbewOff/RDDP9fQkc5jo/sRBXL3oUdcwJrbND X-Received: by 2002:a05:6402:3044:: with SMTP id bu4mr26905005edb.69.1593005326761; Wed, 24 Jun 2020 06:28:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593005326; cv=none; d=google.com; s=arc-20160816; b=BM3tlyRj/b3l4ZGC1sMmIfFiGHxAcW0ztavkE+vvDFvXhEqrrpURtJglrVEhmvXXqJ UUGYfbq8bqwn/VfyiKuJ51e46rkR/yYEm5Yxv+cW7wRA8rfbUnz5lCTZqqyRMlOz4uHG NAF5bQNx+7HJ3G+jtF5QXngNF4mFkHVbowPsz/ZDOKdWewG5v6lN6as5DW19io07QaHp qCHjU/9lR+Pc3u77A+0pF92BRY/fRaxBsXfQL7l3YGBMCQnBijmrv5gJcNv3AQ/yENo8 F3+7o+k0YrWxBdTncSGFH6Ytx90lV0o7RNycPsQ0auyFLW63cA7LG5rdbjRY4a0QAMmi piaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Uvzn5GGmX3qulKFklqhuFpDaBfwgpNZzFNj7oeuicfM=; b=D6VMX+FxEeAg8rA6P1/WzphTWsMSxz8dwYLIE5CIx56wDx1j6JUY8bwNllslwXc2fk QcSNYBqr3c08M0I7fCGLONJPY9vhFYkcfZE6cX2Cf2CJJEuTeUmopwHpoWmYpkuK39S/ T931aKkjS3o9+33M1ZjgcxQZVXlWqr/W1+argfxpK8ViX4us5MFzmxj/zI24wBg2wcBk sKW/c1tDUa0qnVPSSQfRPVISzhhMT5gJ1B7S5hcA8DYVCeXFSODHhngaOmTzjTVOwkKf k6zG15HNboaZ+cIRABUPq8Wyij7IyNVi8X4Hn2V2F7WlWILHIEpFktG3QtVmPogbwANT GEog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DfCE+6p7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l19si6221329eja.516.2020.06.24.06.28.22; Wed, 24 Jun 2020 06:28:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DfCE+6p7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390936AbgFXN1X (ORCPT + 99 others); Wed, 24 Jun 2020 09:27:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:55372 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388365AbgFXN1S (ORCPT ); Wed, 24 Jun 2020 09:27:18 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7BE620738; Wed, 24 Jun 2020 13:27:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593005236; bh=Uvzn5GGmX3qulKFklqhuFpDaBfwgpNZzFNj7oeuicfM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DfCE+6p7BklpNaLNzQGhFErdJ9GEeuS7AoSebSPlnZJF5jsAgVtdGk7vUEwnjQGgM Fn2nQQELoj20anBdPArhIYnmlCcO2McCZEr2SrlB22cC8+EVhVWDkjq3ApDnPNuzAW 6nsZgily1LPUOeIOBI2Li9olPjFfkoKLlrTYAVm0= Date: Wed, 24 Jun 2020 14:27:14 +0100 From: Mark Brown To: Andrzej Hajda Cc: Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, andy.shevchenko@gmail.com, Russell King - ARM Linux , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Daniel Vetter , "open list:DRM DRIVERS" Subject: Re: [RESEND PATCH v5 1/5] driver core: add probe_err log helper Message-ID: <20200624132714.GD5472@sirena.org.uk> References: <20200624114127.3016-1-a.hajda@samsung.com> <20200624114127.3016-2-a.hajda@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EY/WZ/HvNxOox07X" Content-Disposition: inline In-Reply-To: <20200624114127.3016-2-a.hajda@samsung.com> X-Cookie: So this is it. We're going to die. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --EY/WZ/HvNxOox07X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 24, 2020 at 01:41:23PM +0200, Andrzej Hajda wrote: > During probe every time driver gets resource it should usually check for error > printk some message if it is not -EPROBE_DEFER and return the error. This As I said down the thread that's not a great pattern since it means that probe deferral errors never get displayed and users have a hard time figuring out why their driver isn't instantiating. --EY/WZ/HvNxOox07X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7zVLEACgkQJNaLcl1U h9ATPwgAhY22sy/BHlt091VyG8FAdVlhbYN6mk0lzhvHH7Vi9lhuFnpv4CoWIPp9 H3U6sE0bCKLDG8crEhrVfxSMYy8XdDafn37Ua0NYY/gKj3xKfLvZ6SgYAxKN9ljb Fsr2TgqJzAlbV3h5wI9HX8GOzK3YU6qD0lv8QzWu4UU0zkgXD1ty2jIwAa/zv4F0 BvCMvOshZd7pXBg0unqxP0vm3dbOUbC3dup88YjidkmYYYQl8IHbPlrwtDlhVrk3 Eq3t9t69041O+cB6Rg6QIvKAumr/d5BmCqbajAXowB67NKvxxqzOhCIntTqKEiVw U7DHVCCkPY49rXIH1tKz1ahQhgdu5w== =XUqJ -----END PGP SIGNATURE----- --EY/WZ/HvNxOox07X--