Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: iJoK++frYMTOh4efWO2QOAjZ1sbV5DX7KAK/aE980u73ZvwTUiCjHo16Fyq+ona96pqNjIYLAp
 0YD3f818uceg==
IronPort-SDR: cThq9LSaBv5fKEdVFLn7tFTuH25KgEDKBA5g3Xz7GgkH8h7JFIZkBPmbgXQukHKloiaIngpn7U
 +2TdYLvrk33A==
Subject: Re: [PATCH v8 07/13] perf stat: factor out event handling loop into
 dispatch_events()
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <0781a077-aa82-5b4a-273e-c17372a72b93@linux.intel.com>
 <4d90938c-429a-586c-0cc7-767f804c6bce@linux.intel.com>
 <20200623145622.GJ2619137@krava>
From:   Alexey Budankov <alexey.budankov@linux.intel.com>
Organization: Intel Corp.
Message-ID: <4aa8c212-7bc7-3689-03ad-5ce6fd0e6356@linux.intel.com>
Date:   Wed, 24 Jun 2020 16:27:26 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200623145622.GJ2619137@krava>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 23.06.2020 17:56, Jiri Olsa wrote:
> On Wed, Jun 17, 2020 at 11:40:03AM +0300, Alexey Budankov wrote:
>>
>> Consolidate event dispatching loops for fork, attach and system
>> wide monitoring use cases into common dispatch_events() function.
>>
>> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
>> ---
>>  tools/perf/builtin-stat.c | 35 ++++++++++++++++++++++++-----------
>>  1 file changed, 24 insertions(+), 11 deletions(-)
>>
>> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
>> index 3bc538576607..39749c290508 100644
>> --- a/tools/perf/builtin-stat.c
>> +++ b/tools/perf/builtin-stat.c
>> @@ -557,6 +557,27 @@ static bool is_target_alive(struct target *_target,
>>  	return false;
>>  }
>>  
>> +static int dispatch_events(bool forks, int timeout, int interval, int *times, struct timespec *ts)
>> +{
>> +	bool stop = false;
>> +	int child = 0, status = 0;
>> +
>> +	while (1) {
>> +		if (forks)
>> +			child = waitpid(child_pid, &status, WNOHANG);
>> +		else
>> +			child = !is_target_alive(&target, evsel_list->core.threads) ? 1 : 0;
> 
> please renme child to something more accurate, so the condition
> below makes more sense, like child_stoped or such

Well, let's have it named like  child_stopped.

~Alexey

> 
> jirka
> 
>> +
>> +		if (done || stop || child)
>> +			break;
>> +
>> +		nanosleep(ts, NULL);
>> +		stop = process_timeout(timeout, interval, times);
>> +	}
>> +
>> +	return status;
>> +}
>> +
> 
> SNIP
>