Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1593000687-12213-1-git-send-email-Anson.Huang@nxp.com>
 <AM4PR0401MB24016D7F1E97F70AEC23BEB392950@AM4PR0401MB2401.eurprd04.prod.outlook.com>
 <DB3PR0402MB391634C85F53E8A9456E89F0F5950@DB3PR0402MB3916.eurprd04.prod.outlook.com>
In-Reply-To: <DB3PR0402MB391634C85F53E8A9456E89F0F5950@DB3PR0402MB3916.eurprd04.prod.outlook.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Wed, 24 Jun 2020 15:59:41 +0200
Message-ID: <CAK8P3a0avMwB8n2Tw35j1+Ps92jABXUCfsgrTM=jHNmPGmAGUw@mail.gmail.com>
Subject: Re: [PATCH] firmware: imx: Move i.MX SCU soc driver into SCU firmware driver
To:     Anson Huang <anson.huang@nxp.com>
Cc:     Franck Lenormand <franck.lenormand@nxp.com>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will@kernel.org" <will@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        Leo Li <leoyang.li@nxp.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "geert+renesas@glider.be" <geert+renesas@glider.be>,
        "olof@lixom.net" <olof@lixom.net>,
        Leonard Crestez <leonard.crestez@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        Peng Fan <peng.fan@nxp.com>,
        "krzk@kernel.org" <krzk@kernel.org>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 24, 2020 at 3:15 PM Anson Huang <anson.huang@nxp.com> wrote:
>
> Hi, Franck/Arnd
>
> > Subject: RE: [PATCH] firmware: imx: Move i.MX SCU soc driver into SCU
> > firmware driver
> >
> > Hello,
> >
> > The move of folder is a good idea however I do not feel adding the code of
> > soc-imx-scu.c  to imx-scu.c is the best.
> > Until now imx-scu.c was focused on exchanging the RPC and init the IRQ.
> > Why not have soc-imx-scu.c  copied to imx-scu-soc.c (change filename) to
> > have a pattern similar to imx-scu-irq? And keep the  imx_scu_soc_init into
> > imx-scu.c.
> >
> Sound like making sense to me, it can make the code architecture more clear.
>
>         What do you think?

Yes, I agree that is a good idea.

        Arnd