Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp628918ybt;
        Wed, 24 Jun 2020 07:30:11 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzaL99YbSFR94R00+hTbsF9vHstlJ5+vJNmegXKyBUIGel5fcdU25vsuTwGgJbKJVkEk+MI
X-Received: by 2002:a05:6402:22b3:: with SMTP id cx19mr26511403edb.329.1593009011592;
        Wed, 24 Jun 2020 07:30:11 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1593009011; cv=none;
        d=google.com; s=arc-20160816;
        b=KmvRGkEKRq960SBzf43z8KokkVuWh4uFCfhQ4vHUf58S2ZY3Cy/19ZgUVmbr9ug+Wo
         G6PNYiwTa6rgTZljb62Hpgl/gCL1EdmToRzA1T4sIf4E+ulPZji2XVQTM3M5+qvD4lmN
         SlmvirEyWBzg6s0JCM6dPR8Wk4CDPzmFCSxDMwaFEow8CJTPAn1JfHRtnaSSzPq+wHee
         HouTWBe3UfsOVNy1ZFPb64DUEo7kisgF1aURUQRrR/4GkGufYRFI4mSoHpOGYdYCdal3
         fy6yvcvXJRxqamjxElVMbqmCqq+r0H1GBFN0/cb2LNNECJF14koSFm67rJCd0Gax98I4
         XSKw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=B/J/FyLP/cMIITemkspmNPRPSrnTgO5+iMCk+rIrMjM=;
        b=MCMSrfcmLn51U91EOZATaNDyMvFivPag6Tv2U94bqL2bTmAGMMrix6gFRtd/l2l0yr
         Wcj7HQvPYTK9+y9ntMe3Oj6zDOtX263isYL0lWrW0UQ8CQ+Xt+MD4yvlV6NGFML5PVuT
         WtTdCvJuSn027+4E0c4oK7qIeTzSo3JkjCIZQs7DaIycNhf1PfE10htIhjQZznhtprVk
         9jsYHp37HHSDIHxV0s9BsrDO6yq6DoIL8xEQeWOiCcoDwA3MLEooqRtmcWsQpRbRqgtD
         ykodzvASCvN94J/BBJDLwImbnVhfGTE+K8STVa3JXrsr2E5o8bSZvR0fTSLlK5YY0N5A
         LERA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=fTHXbrpC;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id l17si13795557ejf.494.2020.06.24.07.29.48;
        Wed, 24 Jun 2020 07:30:11 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=fTHXbrpC;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2403770AbgFXO15 (ORCPT <rfc822;fezhang.suse@gmail.com>
        + 99 others); Wed, 24 Jun 2020 10:27:57 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50194 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2390161AbgFXO15 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 Jun 2020 10:27:57 -0400
Received: from casper.infradead.org (unknown [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BE7DC061573
        for <linux-kernel@vger.kernel.org>; Wed, 24 Jun 2020 07:27:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=B/J/FyLP/cMIITemkspmNPRPSrnTgO5+iMCk+rIrMjM=; b=fTHXbrpCNIaXRmGIlFIzloHQWu
        BefmN2QQ0pisXXhOvnyQ6qCVkwZyhiaNPwpapudqETMZ0aGNFS538bNGR0AdHhKkeSZ9hvexmFbY4
        VyuOkBd+g8RJ+SQ/JDXH1dvjileLyG8oox+d3kYjVNF9CWK5fv9ZY7UuogIAk+l0EXe22836Eqtkc
        hihNt12XrBJIe6cS2SkYL9IObIRQLhT1dkuKyXJvHbxTQlu9pSdWK0huV+WIxBhEx90g4gBi5uOp7
        y1A/WINxN+h1XIqcC7uuYH6xnrbF9hd2egil1WG3mcF1VHslWgnoNufND0LlhHTH1X6uXlyZGz7lQ
        F2dZvMnQ==;
Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux))
        id 1jo6NI-0000qG-El; Wed, 24 Jun 2020 14:27:40 +0000
Date:   Wed, 24 Jun 2020 15:27:40 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Rafael Aquini <aquini@redhat.com>
Cc:     Joel Savitz <jsavitz@redhat.com>, linux-kernel@vger.kernel.org,
        Vlastimil Babka <vbabka@suse.cz>,
        John Hubbard <jhubbard@nvidia.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: Re: [PATCH] mm/page_alloc: fix documentation error and remove magic
 numbers
Message-ID: <20200624142740.GO21350@casper.infradead.org>
References: <20200624032712.23263-1-jsavitz@redhat.com>
 <20200624111255.GL21350@casper.infradead.org>
 <20200624140727.GA1987277@optiplex-lnx>
 <20200624140958.GN21350@casper.infradead.org>
 <20200624142626.GB1987277@optiplex-lnx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200624142626.GB1987277@optiplex-lnx>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 24, 2020 at 10:26:26AM -0400, Rafael Aquini wrote:
> Joel's approach, however, makes sense if you consider it's generally a 
> good practice to get rid of the unnamed magic numbers anti-pattern.

But I don't.  I care about how easy it is to understand the code, not
conforming to some bullshit trendy word salad.