Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp645915ybt; Wed, 24 Jun 2020 07:54:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvNJARl1hE2kHlTgoDHAZEiLlkGcRayH8qwGPGd1HQ3xgRlYDzO9rRPPsEPsomqo6FfqHP X-Received: by 2002:a50:a45d:: with SMTP id v29mr13957106edb.284.1593010476909; Wed, 24 Jun 2020 07:54:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593010476; cv=none; d=google.com; s=arc-20160816; b=MzP+9A7826RqoXOpulh5BmQyR63YTFdWM4H6xWh54jUKBtlykkF7fDCkFV8/y0PRxM pOvpisIaua02LukBHht2V/daNL/sCSQEp+ttvPAPzmSBcCDP3hgI20jzsnwQwFEuQ3FJ 8w5Mmbx6gk/XRGMsJK1QZR6jppNuvvAfEUW9tq5R2ClX72yStxn2nrHe90Qm9RhWsE9Q zX0WEF7B1gUmDos0/+lVi2ztBJBdKAlp7xYXr/ykeYeE9uqeDhhHq6EfffcoPpcLiJ7T +HQGJ4gl4/Af04Ff9WlxXfe1CSHMsjCXxq2sSOtssbHac+EycM9nxIt3YEKRubERAjhB KiEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=+LYpavnNuYqsfOkUttYqicpUlIfIv5Cp3lganI3VZyY=; b=0Ls8MJTr3yTpCa0AjqRpZpwdoYkQs452PmWxQlAtFD3HZK5s/yiBYF0XIf9mfjaXIy yBICB7PK1A6UyzmHz11/Y8uWdrNYALZyfeZyygsoPXgpCIsIsAwfarp0zChWaK3ROoL3 bdd7IxQWtFyDLyAtL+mQsZq9+/0zWkapbbwXgD1zbacML0LU36d+sByMYMwp3fknLb/r thwdQ14337mRFmrMqoeQ9S+SHHqDMbAXrs5Fc+a5p3BkL9BD5f+nvnUrOvmvDoPVyoxX oum4Hy3awOW/29Miz7nlF8qdssocII87IPmVp1MO86M/cfMYuuuRkNaBobeTZb3vVB8Z fqFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=oOpZTa5+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n6si8387885edq.345.2020.06.24.07.54.13; Wed, 24 Jun 2020 07:54:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=oOpZTa5+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390826AbgFXOwK (ORCPT + 99 others); Wed, 24 Jun 2020 10:52:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389400AbgFXOwJ (ORCPT ); Wed, 24 Jun 2020 10:52:09 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 814F8C061573 for ; Wed, 24 Jun 2020 07:52:08 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id p3so1539268pgh.3 for ; Wed, 24 Jun 2020 07:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+LYpavnNuYqsfOkUttYqicpUlIfIv5Cp3lganI3VZyY=; b=oOpZTa5+wogd5Zo5i06YBiLJFA99TNpd/R+dpAjxia0I1HX72p/pYJ8+r7FI6VpwER kzA4slLqc797d9hmoYdf7UkLvHZBonG0ASsGwrh3JEmkqkxa0R9ukdqOi+fcffkssEzd F5YHRwr3LVOa1RW5jvA3hKVCIR9zUCv3CwZ08= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+LYpavnNuYqsfOkUttYqicpUlIfIv5Cp3lganI3VZyY=; b=qR3MGL2PdQbR1jmltsX7fZPikDv7G34lUtQ2f8coDrlIdchlHE1wQVb4HsUOmBfcpF PGQfsl4b2v5IrUEuHDRTzZf0xU8wQw5wbiV7gYb2uojvbJu56y+8RbI9IoQ2LlFJITVQ axsR4JULkkPp0traxQrJ/++/1bbzB5JSZZdFBagHeYqgQnpYsLTGcGHO24HwxrASkTpV gaTd4Cmq1hCs+d3hyoNaowDTL0lOAnvjjSZNMx1JwpU95kCMceicKizNNq3ZCvlacNel K/4nLA95ilnikFrtEWmy/pqDPioI6tVGviWIK1NEXD9ndzBbxOGX4MiA2j5mFhV4DeAe 9h4g== X-Gm-Message-State: AOAM533Bq+TCfenR77Zk9xEIwxNX5AqNNK4Hf5IDvGNYpzFRMI/nTi/4 d2EBkJiPCVXzxaUngnqTsG89ig== X-Received: by 2002:a63:8b42:: with SMTP id j63mr22776554pge.131.1593010327982; Wed, 24 Jun 2020 07:52:07 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id cm13sm5609737pjb.5.2020.06.24.07.52.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 07:52:07 -0700 (PDT) Date: Wed, 24 Jun 2020 07:52:06 -0700 From: Kees Cook To: Alexander Popov Cc: Jann Horn , Emese Revfy , Miguel Ojeda , Masahiro Yamada , Michal Marek , Andrew Morton , Masahiro Yamada , Thiago Jung Bauermann , Luis Chamberlain , Jessica Yu , Sven Schnelle , Iurii Zaikin , Catalin Marinas , Will Deacon , Vincenzo Frascino , Thomas Gleixner , Peter Collingbourne , Naohiro Aota , Alexander Monakov , Mathias Krause , PaX Team , Brad Spengler , Laura Abbott , Florian Weimer , kernel-hardening@lists.openwall.com, linux-kbuild@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gcc@gcc.gnu.org, notify@kernel.org Subject: Re: [PATCH v2 1/5] gcc-plugins/stackleak: Don't instrument itself Message-ID: <202006240751.30293A1@keescook> References: <20200624123330.83226-1-alex.popov@linux.com> <20200624123330.83226-2-alex.popov@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624123330.83226-2-alex.popov@linux.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 24, 2020 at 03:33:26PM +0300, Alexander Popov wrote: > There is no need to try instrumenting functions in kernel/stackleak.c. > Otherwise that can cause issues if the cleanup pass of stackleak gcc plugin > is disabled. > > Signed-off-by: Alexander Popov > Acked-by: Kees Cook Thanks! Applied to for-next/gcc-plugins. -- Kees Cook