Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp653861ybt; Wed, 24 Jun 2020 08:05:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJU65vnloVXhvN1uWP/Y61L+zaAcnhR1xJIo36o3TYi5X9vaNvePIg0F+ZFdIckLF0cbvB X-Received: by 2002:a17:906:2c43:: with SMTP id f3mr1095060ejh.38.1593011116431; Wed, 24 Jun 2020 08:05:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593011116; cv=none; d=google.com; s=arc-20160816; b=VR4A+CPWsKOPD2r30tLBMAnJgzuAb4+YEGZotxoHWfEjJkn6nLjdRlMKD512REu/e0 bOnllF/bw0iw2cYPBsHQd0yJ3AGbdFd5KhOqoFHk9IcV+V4+N/+Mbxw7sMvEw+M2MyRL JSQz+v3C0PieCskZl5yc6t/8ulQnVNmA5vW4q0NPGfeUxL54a51izcke2gD1vNt94VWz sS2oQLMYoD2KwS3aW3OZscCB0tTR5mp6dbSOszb8F/cQMzF8jXPxxKoaBru3m0lLs0Dy CpMHqG5SEF5Zu80fzsWKCQRb25X/eVAyHuQIvzjrcaG8b1ieL1ezj1DE08pN76QTysNa iceg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sjyWN89n2WVn1nir58rJre28qTxK1Z7LKlW6WPjB498=; b=dFzWyauiekScXp/38nvHBK+6Ve0SI1E/ODg9jfheNx7PaxgVGlPRNxr54w97v4PRkD 8BzbBpK6wmJ9UHgmqnKXZAYB9C+3AAkSrORQ/XPlmL8fVKqp/XXo8j2GJvsj0z3O4eN4 mbHgAf+VqgOaC5a0S9NY4k5xZbjsdnpg2qy0HDOCn5PSc0tbHncB7YyYg4z+oMtGK1S2 orgzMVlC+1QEYEqaTt41jiJQIfYQ6EnOuQTEU39u30XEC8QYGOiBjRo2LCYzPblWnjaH 6VPSVdqTu2xWea8MlVurHPlhrPJEP2PU6MSZk3+q1pPghEDVbEIt6vaXpgxEVr6tBaZf +qcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OuktBilc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lm17si3118373ejb.366.2020.06.24.08.04.52; Wed, 24 Jun 2020 08:05:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OuktBilc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404071AbgFXPEh (ORCPT + 99 others); Wed, 24 Jun 2020 11:04:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:46814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403833AbgFXPEh (ORCPT ); Wed, 24 Jun 2020 11:04:37 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F352C2070A; Wed, 24 Jun 2020 15:04:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593011076; bh=sjyWN89n2WVn1nir58rJre28qTxK1Z7LKlW6WPjB498=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OuktBilcZV/yDm2z+dLzle3X5u04XthtuHlAreC1y/MG37F7osJCt8BQdho0fFtnr Zbqy05zYZlwITMtBKJjdgZIWp5dN5nafQF6fts3sxdifBfIuD3LxBGLbx0T8m0No9r Vs25zXTH+3WgSZPmxueQywLc30VHf7n177WG8R10= Date: Wed, 24 Jun 2020 16:04:34 +0100 From: Mark Brown To: Robin Murphy Cc: Andy Shevchenko , Andrzej Hajda , Greg Kroah-Hartman , Jernej Skrabec , "Rafael J. Wysocki" , Jonas Karlman , Bartlomiej Zolnierkiewicz , Linux Kernel Mailing List , "open list:DRM DRIVERS" , Russell King - ARM Linux , Neil Armstrong , Laurent Pinchart , Daniel Vetter , linux-arm Mailing List , Marek Szyprowski Subject: Re: [RESEND PATCH v5 3/5] drivers core: allow probe_err accept integer and pointer types Message-ID: <20200624150434.GH5472@sirena.org.uk> References: <20200624114127.3016-1-a.hajda@samsung.com> <20200624114127.3016-4-a.hajda@samsung.com> <2203e0c2-016b-4dbe-452d-63c857f06dd1@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4C6bbPZ6c/S1npyF" Content-Disposition: inline In-Reply-To: X-Cookie: So this is it. We're going to die. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4C6bbPZ6c/S1npyF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 24, 2020 at 03:25:33PM +0100, Robin Murphy wrote: > And yeah, anyone who pipes up suggesting that places where an ERR_PTR value > could be passed to probe_err() could simply refactor IS_ERR() checks with > more uses of the god-awful PTR_ERR_OR_ZERO() obfuscator gets a long stare of > disapproval... We could also have a probe_err_ptr() or something that took an ERR_PTR() instead if there really were an issue with explicitly doing this. --4C6bbPZ6c/S1npyF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7za4EACgkQJNaLcl1U h9ADKQf/bUGsVZLtJzgP2M/GIXNWTFrshhTPYFVHuKWmwRJL79fSW758BKdmbzdF fYDZdgI3NMUnfpBaL7MmdmAlazwJ97Mci7lVIckChwBKZWo7QT/oe8RZlp+mGlbr 6kSNJDIQgTdBEtx1T6VYHhEnZgjn5KRgZHTp2SVd1SaJ6StGr2w29XvLABxfekXl OLdDcSIHN0eUWZoLx/fjDrB3Wic9JzbEzj7rFZ6Zfr5py3VxUseRexpXikjW9YEa VejUE8Z0brYa021cZqMymq0G++v+JeATDEzCsYMJ3VGsHgBfSVJrIHfxtx9dJHv+ dHEFhwK7rmIkGPziGlBbph8Bncxuhg== =wsw7 -----END PGP SIGNATURE----- --4C6bbPZ6c/S1npyF--