Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932102AbWC1Ktb (ORCPT ); Tue, 28 Mar 2006 05:49:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932182AbWC1Ktb (ORCPT ); Tue, 28 Mar 2006 05:49:31 -0500 Received: from ns2.suse.de ([195.135.220.15]:46217 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S932102AbWC1Ktb (ORCPT ); Tue, 28 Mar 2006 05:49:31 -0500 Date: Tue, 28 Mar 2006 12:49:25 +0200 Message-ID: From: Takashi Iwai To: Rene Herman Cc: ALSA devel , Adrian Bunk , Linux Kernel Subject: Re: [ALSA] AdLib FM card driver In-Reply-To: <442812E4.5060803@keyaccess.nl> References: <442710A1.5030207@keyaccess.nl> <44281194.50800@keyaccess.nl> <442812E4.5060803@keyaccess.nl> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25) (eggplant) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1080 Lines: 27 At Mon, 27 Mar 2006 18:29:24 +0200, Rene Herman wrote: > > Rene Herman wrote: > > > Attached is a version that simply jumps to a return -EINVAL, which > > would also be the easiest way to fixup the others, at least for > > -stable. If you disagree though, in the next message I'll sent a > > version that does register the error, but for now just turns them > > into -EINVAL before returning. > > As promised. As said, I prefer the previous one. With this one, it would > only be a matter of deleting the "error = -EINVAL;" lines again to have > it propagate the error up after a resolution of that -ENODEV | -ENXIO > thing, but since the value isn't used anyway... Thanks, it's now in ALSA CVS tree (with a minor modification, error = -EINVAL is set just before return). It should be propagated to 2.6.17 soon later. Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/