Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp714448ybt; Wed, 24 Jun 2020 09:25:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnBl8NanaBluW83psESb9R8KEhqIh4Bu2v03OuFXVWVJIDnYFz7+YUpm9hrzCQiPU+mqMU X-Received: by 2002:a17:906:148b:: with SMTP id x11mr26963703ejc.282.1593015931084; Wed, 24 Jun 2020 09:25:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593015931; cv=none; d=google.com; s=arc-20160816; b=iphFWCiud1FdHo2iN8pzTE5Q6ZP5VwvghHmEXAb8edP/t7u6eKLEAv/LbB3vO573UI Uem9FWdQNuJ247z0rVUVHoT8BsRr1XuuBAnP/WmGyBudYpuzPYaPCLXhpLnHvPfzq1N6 GILevNQjRzELnoyHo79ouRv6p0cxUUt3PPuVrIZ3noX7j9zdKWKCAG4H31GlGI72gU6w 7PVA8gKEU72zWGJuYMLgpDECY9447YOcQcObNX1vHYXrDcrDiSmAHYdBx90czBzeaJqj xN5m4rf0ry0MYWytFiJkdmeevtlB7dkae5Q2mCes5XNTORNfCJ/DY/NLz0Um9Epvw9wc PPaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=9bnVOoXg509juKgEEccE6gNXpJT63oPQhPcJewIyDbs=; b=sM1YE2BRL3Meq1US2wzarVDmlb4sJvlItCAkeGhXbXuDV3AoaHKAlNFZ+4jb+p9VvY y3vCNUq9Lk3BJNf4EvcVgHjESZlyLoMQjnh/hHNoo7lk5lMrTt5wnDxV9AMzuFybmuOw waky6xm0rAXU+0iY55BEDib/4y/KZHhunNzrByFoyV3bvcmX60ZhEL9TkGMhYHyZa5eY lyP1IXHgjicRhTo8W8rPbrYyc7GsbORtJZXqjv4oZzkaYYcx7oYPvw8i8Jg6baRFDN5B HKeEUBJo5a9SW9+bzkb1/6dc9lHfXlaCGcJBx4bxZ+gzQYl3NpbRjyNgQtiJerCh9GrE nTAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b="j/Z1FPcX"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fi17si6606607ejb.724.2020.06.24.09.25.08; Wed, 24 Jun 2020 09:25:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b="j/Z1FPcX"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404926AbgFXQYc (ORCPT + 99 others); Wed, 24 Jun 2020 12:24:32 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:64758 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2404468AbgFXQYb (ORCPT ); Wed, 24 Jun 2020 12:24:31 -0400 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05OGOFiA018499; Wed, 24 Jun 2020 11:24:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=9bnVOoXg509juKgEEccE6gNXpJT63oPQhPcJewIyDbs=; b=j/Z1FPcXnp1aiM/TUW91h7XBeMmQhQV2hSc5hXrtPTLVMJimAzvmj9eX3XRhz5bSWViS 8FrpcSsNnR6IsLBjnKVpdhFjit3Ur7IEFarEw18oQ/FMa16DfZGOt9LI6HWHl+Q+W+63 wkAdPWid2u+Idjxjg3c+HTu6IsX6b96aimmt0IlTyyPiKtQ4L+cWArA5Nl8pRvjhj4iH wTT86FExAf6xOm9Ck75rJ0QX3BLPlP7p6iTlS1i/4wh4KhKPF5PMGJ4Y6/VKiFWKlREB jZPYlcGXfBV6J1M3Lz++q4fgA6Z4+/Ce5EyMzylBOdDRX6z881/LvCHEZf9z8Q6muP6p Aw== Authentication-Results: ppops.net; spf=fail smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0a-001ae601.pphosted.com with ESMTP id 31uus3953a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 24 Jun 2020 11:24:27 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Wed, 24 Jun 2020 17:24:25 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Wed, 24 Jun 2020 17:24:25 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 4AFC32C5; Wed, 24 Jun 2020 16:24:25 +0000 (UTC) Date: Wed, 24 Jun 2020 16:24:25 +0000 From: Charles Keepax To: Lee Jones CC: , , , Mark Brown , Subject: Re: [PATCH 10/10] mfd: wm831x-core: Supply description wm831x_reg_{un}lock args Message-ID: <20200624162425.GZ71940@ediswmail.ad.cirrus.com> References: <20200624150704.2729736-1-lee.jones@linaro.org> <20200624150704.2729736-11-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200624150704.2729736-11-lee.jones@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-SPF-Result: fail X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com include:spf.protection.outlook.com ip4:5.172.152.52 -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 mlxlogscore=832 phishscore=0 spamscore=0 cotscore=-2147483648 impostorscore=0 priorityscore=1501 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006240112 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 24, 2020 at 04:07:04PM +0100, Lee Jones wrote: > Kerneldoc syntax is used, but not complete. Descriptions required. > > Prevents warnings like: > > drivers/mfd/wm831x-core.c:119: warning: Function parameter or member 'wm831x' not described in 'wm831x_reg_lock' > drivers/mfd/wm831x-core.c:145: warning: Function parameter or member 'wm831x' not described in 'wm831x_reg_unlock' > > Cc: > Cc: Mark Brown > Cc: patches@opensource.cirrus.com > Signed-off-by: Lee Jones > --- Acked-by: Charles Keepax Thanks, Charles