Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1593020612-13051-1-git-send-email-yang.shi@linux.alibaba.com>
In-Reply-To: <1593020612-13051-1-git-send-email-yang.shi@linux.alibaba.com>
From:   Shakeel Butt <shakeelb@google.com>
Date:   Wed, 24 Jun 2020 12:49:52 -0700
Message-ID: <CALvZod4+YxWbUJF5yCRkzOeT7-Kt0CHMPMFskKL5bfhk0BG=8g@mail.gmail.com>
Subject: Re: [PATCH] mm: filemap: clear idle flag for writes
To:     Yang Shi <yang.shi@linux.alibaba.com>
Cc:     Johannes Weiner <hannes@cmpxchg.org>,
        Rik van Riel <riel@surriel.com>, gavin.dg@linux.alibaba.com,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 24, 2020 at 10:43 AM Yang Shi <yang.shi@linux.alibaba.com> wrote:
>
> Since commit bbddabe2e436aa7869b3ac5248df5c14ddde0cbf ("mm: filemap:
> only do access activations on reads"), mark_page_accessed() is called
> for reads only.  But the idle flag is cleared by mark_page_accessed() so
> the idle flag won't get cleared if the page is write accessed only.
>
> Basically idle page tracking is used to estimate workingset size of
> workload, noticeable size of workingset might be missed if the idle flag
> is not maintained correctly.
>
> It seems good enough to just clear idle flag for write operations.
>
> Fixes: bbddabe2e436 ("mm: filemap: only do access activations on reads")
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Rik van Riel <riel@surriel.com>
> Cc: Shakeel Butt <shakeelb@google.com>
> Reported-by: Gang Deng <gavin.dg@linux.alibaba.com>
> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>

Reviewed-by: Shakeel Butt <shakeelb@google.com>