Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp931075ybt; Wed, 24 Jun 2020 15:09:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPhi8BCbI/Defo3dw45HcKeCd/jIGTiqRV0q3FIU+BLdyeiCOBSiYbA7VZYqmHycnnR8vJ X-Received: by 2002:a50:c8c9:: with SMTP id k9mr28035949edh.157.1593036562367; Wed, 24 Jun 2020 15:09:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593036562; cv=none; d=google.com; s=arc-20160816; b=D+qPhUFNayEpQABjHufOH2X1MsqDkiOaWPct6NvFtkzeD95VPJgIIjYsZUeeqm1p9k VYJRRJeO2Fz5juehLdFrmvJP8b572hx6Ioxwi1Wpmp14t44DNf033cXfblofgdHbzhYQ i9gCh6iZ1fht5aefEufPCNEvEoHTtdJKCe1/YbsoJPzY/AlEZD0IKikzmuV7j1X5UYkQ Sf+8XcT1J/zAYF7pu7sx/zRaBPVwtj35VviFYIVQsQb3+rlMLfWIK0BjL0yi/JEasde2 li9EbcstUE65uxGd6Ly94ynY65sRfa0OrTOvy+sSeOxRHE2QyEf2gjEOBVPEw2NcjhH0 JRsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=IyCksYvXsGxnlxYS4+6Aipp1qR5shFL0JQ1DYFY54iU=; b=rWWR7C29JevufbmYsFqkvUFJWCxwLxDd/OpftKOd1EPwowZikdomySLI3GQ7q6ZUMm xryvhwz9OPfE3O4a8j9dwOdY4Ywg4OwFiru5PdT0fVNOI7thAJGLDNK/HOo9FdZiXkEe T99/TztHZW1W5qYEJ51pfXntKBSN2NgLdeKVfBb1QRX7s/xBT9wo0fY2GTAJjFshWmXI YhDNjEDR8meo/zGtlG9+PcNYUSvJ6M3HF5ZZGuDqRGny87Xem+82Hpsz9uBvPK461HDh 65Niip/WuDwaxJ7bk1pD2ZFKiOoc9VJT7xZJIO6LT5KgfzF20AlvhouAgqFSEWn0UkRc Pfgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f9si5389638edy.84.2020.06.24.15.08.59; Wed, 24 Jun 2020 15:09:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404824AbgFXVsM (ORCPT + 99 others); Wed, 24 Jun 2020 17:48:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404563AbgFXVsM (ORCPT ); Wed, 24 Jun 2020 17:48:12 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33B4EC061573; Wed, 24 Jun 2020 14:48:12 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9C09F12737AF7; Wed, 24 Jun 2020 14:48:11 -0700 (PDT) Date: Wed, 24 Jun 2020 14:48:10 -0700 (PDT) Message-Id: <20200624.144810.1787595389624931255.davem@davemloft.net> To: s.hauer@pengutronix.de Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@bootlin.com, kernel@pengutronix.de, linux@armlinux.org.uk Subject: Re: [PATCH 1/2] net: ethernet: mvneta: Do not error out in non serdes modes From: David Miller In-Reply-To: <20200624070045.8878-1-s.hauer@pengutronix.de> References: <20200624070045.8878-1-s.hauer@pengutronix.de> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 24 Jun 2020 14:48:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sascha Hauer Date: Wed, 24 Jun 2020 09:00:44 +0200 > In mvneta_config_interface() the RGMII modes are catched by the default > case which is an error return. The RGMII modes are valid modes for the > driver, so instead of returning an error add a break statement to return > successfully. > > This avoids this warning for non comphy SoCs which use RGMII, like > SolidRun Clearfog: > > WARNING: CPU: 0 PID: 268 at drivers/net/ethernet/marvell/mvneta.c:3512 mvneta_start_dev+0x220/0x23c > > Signed-off-by: Sascha Hauer Applied.