Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp931742ybt; Wed, 24 Jun 2020 15:10:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJylz6Ll/7OEaeHAJsaYP9JrurKLFO8LjxsiBmjt+sVjgotXw9LGdBp/aOXw816dGj1SkY3S X-Received: by 2002:a17:906:fcab:: with SMTP id qw11mr13914159ejb.456.1593036624467; Wed, 24 Jun 2020 15:10:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593036624; cv=none; d=google.com; s=arc-20160816; b=EtBCLbGyBycybJmhGiBk9NT/ZJvRMlrxPEq5BjAujBurPsQ85ML/2XZfGhTq+YcSKc 7WT3XmgBd63/dC6jERGnRWkzRYPK3f5dv+ZoT85W9HIHW5DTlM1zZP04PeZOot5jWM8r 3mPRJvVo0y0TEL4rZA2saH27BrnP3SBtQC7hXPad42vwDXMV8dJBl6klLOTTbXp7fwrg EvK6fRUekxOpoUMmgUmj5ablOGq0C0DdQmkGx98r7vepmV+0nginkFFCQ1Uf8MXqtjJQ qm7J5M5sWjH/udXoS1FdTX10aMCjVNmqq6PhqpSqL6UCdlyU4O10cVljlOhukuUf4+MT 5ZPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=jXFggczwLqJQ9eZ+aWhXEsXnAx7pMgn5w74E4q5N9hk=; b=URH0oD7QERAuFI11bT1vCvmceBqkVdZgls/bj0foOZ4NMXMv/nU0ihiWHohKbavvTx MoR9en+CZIwWxghnQRrtD8AkSWhsDrPQ2ldI3YXqcE4ot29IH+37dLvi0hh0/f5Miv7N BsnOVl1gmR0jS6LHTGQ2G8f0vfdJRslkxGtgoLlvKD4WhSr4poQQeNqZ+olcw3dLu5Tv SPESQlZvX4+UO+DqcCxcO/EuFrAPSz19YlQMngoFniCotbVb+jKrOJQeKZs1/HvKZ6sP One/5KhFAeqCxkAKzZae7bHm6al4V0tSirN13rIMkVKLdqvGTYRVvJ3HpVyvarCqSA+r s1tQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v25si7030487ejx.496.2020.06.24.15.10.00; Wed, 24 Jun 2020 15:10:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390042AbgFXV55 (ORCPT + 99 others); Wed, 24 Jun 2020 17:57:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729463AbgFXV54 (ORCPT ); Wed, 24 Jun 2020 17:57:56 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B148FC061573; Wed, 24 Jun 2020 14:57:56 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 378511273DEC1; Wed, 24 Jun 2020 14:57:56 -0700 (PDT) Date: Wed, 24 Jun 2020 14:57:55 -0700 (PDT) Message-Id: <20200624.145755.1271879668840297330.davem@davemloft.net> To: colin.king@canonical.com Cc: aelior@marvell.com, GR-everest-linux-l2@marvell.com, kuba@kernel.org, michal.kalderon@marvell.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE From: David Miller In-Reply-To: <20200624101302.8316-1-colin.king@canonical.com> References: <20200624101302.8316-1-colin.king@canonical.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 24 Jun 2020 14:57:56 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Wed, 24 Jun 2020 11:13:02 +0100 > From: Colin Ian King > > The error DBG_STATUS_NO_MATCHING_FRAMING_MODE was added to the enum > enum dbg_status however there is a missing corresponding entry for > this in the array s_status_str. This causes an out-of-bounds read when > indexing into the last entry of s_status_str. Fix this by adding in > the missing entry. > > Addresses-Coverity: ("Out-of-bounds read"). > Fixes: 2d22bc8354b1 ("qed: FW 8.42.2.0 debug features") > Signed-off-by: Colin Ian King Applied, thank you.