Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?iso-2022-jp?B?SE9SSUdVQ0hJIE5BT1lBKBskQktZOH0hIUQ+TGkbKEIp?= 
        <naoya.horiguchi@nec.com>
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     "nao.horiguchi@gmail.com" <nao.horiguchi@gmail.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "mhocko@kernel.org" <mhocko@kernel.org>,
        "mike.kravetz@oracle.com" <mike.kravetz@oracle.com>,
        "osalvador@suse.de" <osalvador@suse.de>,
        "tony.luck@intel.com" <tony.luck@intel.com>,
        "david@redhat.com" <david@redhat.com>,
        "aneesh.kumar@linux.vnet.ibm.com" <aneesh.kumar@linux.vnet.ibm.com>,
        "zeil@yandex-team.ru" <zeil@yandex-team.ru>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 00/15] HWPOISON: soft offline rework
Thread-Topic: [PATCH v3 00/15] HWPOISON: soft offline rework
Thread-Index: AQHWSlwottUppHD7sEaxjlCDSVewGKjoWwgAgAADxICAAANSAA==
Date:   Wed, 24 Jun 2020 23:01:41 +0000
Message-ID: <20200624230140.GA13052@hori.linux.bs1.fc.nec.co.jp>
References: <20200624150137.7052-1-nao.horiguchi@gmail.com>
 <20200624121742.711331a2a65633a0e16fd9e6@linux-foundation.org>
 <20200624223618.GA13133@hori.linux.bs1.fc.nec.co.jp>
 <20200624154947.2f41c426d4b83fb9241d8584@linux-foundation.org>
In-Reply-To: <20200624154947.2f41c426d4b83fb9241d8584@linux-foundation.org>
Accept-Language: ja-JP, en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-2022-jp"
Content-ID: <B7CD0E4C7E1B0E479940EACBFB2DBBE3@jpnprd01.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: efb62a9b-a34f-4d2c-2a04-08d818928eba
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2020 23:01:41.0522
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: e67df547-9d0d-4f4d-9161-51c6ed1f7d11
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /4S2iVgbJHW/AIkDNg/XqbUhAC0/jWbcKXEXaIDj94dyG50avuBSUBSV+GJQLQabKvMYRNptHHupGoHaYdcaQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR01MB1612
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 24, 2020 at 03:49:47PM -0700, Andrew Morton wrote:
> On Wed, 24 Jun 2020 22:36:18 +0000 HORIGUCHI NAOYA(=1B$BKY8}!!D>Li=1B(B) =
<naoya.horiguchi@nec.com> wrote:
>=20
> > On Wed, Jun 24, 2020 at 12:17:42PM -0700, Andrew Morton wrote:
> > > On Wed, 24 Jun 2020 15:01:22 +0000 nao.horiguchi@gmail.com wrote:
> > >=20
> > > > I rebased soft-offline rework patchset [1][2] onto the latest mmotm=
.  The
> > > > rebasing required some non-trivial changes to adjust, but mainly th=
at was
> > > > straightforward.  I confirmed that the reported problem doesn't rep=
roduce on
> > > > compaction after soft offline.  For more precise description of the=
 problem
> > > > and the motivation of this patchset, please see [2].
> > > >=20
> > > > I think that the following two patches in v2 are better to be done =
with
> > > > separate work of hard-offline rework, so it's not included in this =
series.
> > > >=20
> > > >   - mm,hwpoison: Take pages off the buddy when hard-offlining
> > > >   - mm/hwpoison-inject: Rip off duplicated checks
> > > >=20
> > > > These two are not directly related to the reported problem, so they=
 seems
> > > > not urgent.  And the first one breaks num_poisoned_pages counting i=
n some
> > > > testcases, and The second patch needs more consideration about comm=
ented point.
> > > >=20
> > >=20
> > > It would be nice to have some sort of overview of the patch series in
> > > this [0/n] email.
> > >=20
> > > > [1] v1: https://lore.kernel.org/linux-mm/1541746035-13408-1-git-sen=
d-email-n-horiguchi@ah.jp.nec.com/
> > > > [2] v2: https://lore.kernel.org/linux-mm/20191017142123.24245-1-osa=
lvador@suse.de/
> > >=20
> > > The above have such, but are they up to date?
> >=20
> > The description of the problem doesn't change, but there're some new pa=
tches
> > and some patches are postponed, so I should've added an overview of thi=
s series:
> >=20
> > - patch 1, 2 are cleanups.
> > - patch 3, 4, 5 change the precondition when calling memory_failure(). =
Previously
> >   we sometimes call it with holding refcount of the target page and som=
times call
> >   without holding it, and we passed a flag of whether refcount was take=
n out of
> >   memory_failure().  It was confusing and caused code more complex than=
 needed.
> > - patch 6-10 are cleanups.
> > - patch 11 introduces new logic to remove the error page from buddy all=
ocator,
> >   which is also applied to the path of soft-offling in-use pages in pat=
ch 12.
> > - patch 13 is basically a refactoring but I added some adjustment to ma=
ke sure
> >   that the freed page is surely sent back to buddy instead of being kep=
t in pcplist,
> >   which is based on discussion in v2.
> > - patch 14 fixes the inconsistency of return values between injection i=
nterfaces.
> > - patch 15 is a new patch to complement missing code found in code revi=
ew for
> >   previous version.
> >=20
> > Core change is in patch 11 and 12, and the others are kind of cleanup/r=
efactoring.
>=20
> And all the other words in
> https://lore.kernel.org/linux-mm/1541746035-13408-1-git-send-email-n-hori=
guchi@ah.jp.nec.com/
> are still accurate and complete?

Yes, they are.

- Naoya=