Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200624150704.2729736-1-lee.jones@linaro.org> <20200624150704.2729736-6-lee.jones@linaro.org>
In-Reply-To: <20200624150704.2729736-6-lee.jones@linaro.org>
From:   Baolin Wang <baolin.wang7@gmail.com>
Date:   Thu, 25 Jun 2020 10:46:37 +0800
Message-ID: <CADBw62pJZbHXwbKc36qJ=dATHyZDU=yw6Z+krWi47AJmotqEvA@mail.gmail.com>
Subject: Re: [PATCH 05/10] mfd: sprd-sc27xx-spi: Fix symbol
 'sprd_pmic_detect_charger_type' was not declared warning
To:     Lee Jones <lee.jones@linaro.org>
Cc:     linux-arm-kernel@lists.infradead.org,
        LKML <linux-kernel@vger.kernel.org>, stable@vger.kernel.org,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Lee,

On Wed, Jun 24, 2020 at 11:07 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Sparse reports:
>
>  drivers/mfd/sprd-sc27xx-spi.c:59:23: warning: symbol 'sprd_pmic_detect_charger_type' was not declared. Should it be static?
>
> ... due to a missing header file.
>
> Cc: <stable@vger.kernel.org>
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Baolin Wang <baolin.wang7@gmail.com>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Thanks.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>

> ---
>  drivers/mfd/sprd-sc27xx-spi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> index 33336cde47243..c305e941e435c 100644
> --- a/drivers/mfd/sprd-sc27xx-spi.c
> +++ b/drivers/mfd/sprd-sc27xx-spi.c
> @@ -7,6 +7,7 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/mfd/core.h>
> +#include <linux/mfd/sc27xx-pmic.h>
>  #include <linux/of_device.h>
>  #include <linux/regmap.h>
>  #include <linux/spi/spi.h>
> --
> 2.25.1
>


-- 
Baolin Wang