Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1593044164-32362-1-git-send-email-Anson.Huang@nxp.com>
In-Reply-To: <1593044164-32362-1-git-send-email-Anson.Huang@nxp.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Thu, 25 Jun 2020 10:12:57 +0200
Message-ID: <CAK8P3a2uh2eBHE+XPt1gUDEj0vnXwES-GmL=rsBRDHpK5HXc0A@mail.gmail.com>
Subject: Re: [PATCH V2] firmware: imx: Move i.MX SCU soc driver into imx
 firmware folder
To:     Anson Huang <Anson.Huang@nxp.com>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Sascha Hauer <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Leo Li <leoyang.li@nxp.com>, Vinod Koul <vkoul@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Olof Johansson <olof@lixom.net>, Peng Fan <peng.fan@nxp.com>,
        Dong Aisheng <aisheng.dong@nxp.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Franck Lenormand <franck.lenormand@nxp.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        NXP Linux Team <Linux-imx@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 25, 2020 at 2:27 AM Anson Huang <Anson.Huang@nxp.com> wrote:
>
> The i.MX SCU soc driver depends on SCU firmware driver, so it has to
> use platform driver model for proper defer probe operation, since
> it has no device binding in DT file, a simple platform device is
> created together inside the platform driver. To make it more clean,
> we can just move the entire SCU soc driver into imx firmware folder
> and initialized by i.MX SCU firmware driver.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Looks good except for one irritating issue:

> index 17ea361..b76acba 100644
> --- a/drivers/firmware/imx/Makefile
> +++ b/drivers/firmware/imx/Makefile
> @@ -1,4 +1,4 @@
>  # SPDX-License-Identifier: GPL-2.0
>  obj-$(CONFIG_IMX_DSP)          += imx-dsp.o
> -obj-$(CONFIG_IMX_SCU)          += imx-scu.o misc.o imx-scu-irq.o rm.o
> +obj-$(CONFIG_IMX_SCU)          += imx-scu.o misc.o imx-scu-irq.o rm.o imx-scu-soc.o
>  obj-$(CONFIG_IMX_SCU_PD)       += scu-pd.o

This makes separate loadable modules out of the driver when CONFIG_IMX_SCU=m,
including the badly named misc.ko and rm.ko modules that might conflict
with other modules of the same name (module names are a global namespace
for modprobe).

The way to make this a single module from four files is

obj-$(CONFIG_IMX_SCU)          += imx-scu-mod.o
imx-scu-mod-y := imx-scu.o misc.o imx-scu-irq.o rm.o imx-scu-soc.o

> +EXPORT_SYMBOL(imx_scu_soc_init);

Consequently, there should not be an EXPORT_SYMBOL here.

       Arnd