Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 4/7] arm64: dts: mt8183: Fix unit name warnings
To:     Matthias Brugger <matthias.bgg@gmail.com>,
        linux-kernel@vger.kernel.org
Cc:     Collabora Kernel ML <kernel@collabora.com>, erwanaliasr1@gmail.com,
        drinkcat@chromium.org, hsinyi@chromium.org,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
References: <20200619102757.1358675-1-enric.balletbo@collabora.com>
 <20200619102757.1358675-5-enric.balletbo@collabora.com>
 <ec4fb6c1-37a3-08b2-ae57-3e35868383ef@gmail.com>
From:   Enric Balletbo i Serra <enric.balletbo@collabora.com>
Message-ID: <c519de37-1377-9860-d831-0781c259cc0c@collabora.com>
Date:   Thu, 25 Jun 2020 10:39:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <ec4fb6c1-37a3-08b2-ae57-3e35868383ef@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Matthias,

Thank you for you review.

On 22/6/20 12:14, Matthias Brugger wrote:
> 
> 
> On 19/06/2020 12:27, Enric Balletbo i Serra wrote:
>> Remove the unit address from the DT nodes that doesn't have a reg
>> property. This fixes the following unit name warnings:
>>
>>   Warning (unit_address_vs_reg): /cpus/idle-states/cluster-sleep@0: node has a unit name, but no reg or ranges property
>>   Warning (unit_address_vs_reg): /cpus/idle-states/cluster-sleep@1: node has a unit name, but no reg or ranges property
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> ---
>>
>>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index 00137ec61164d..e356076749148 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -168,7 +168,7 @@ CPU_SLEEP: cpu-sleep {
>>  				min-residency-us = <800>;
>>  			};
>>  
>> -			CLUSTER_SLEEP0: cluster-sleep@0 {
>> +			CLUSTER_SLEEP0: cluster-sleep0 {
> 
> Should be:
> cluster-sleep-0
> 

Ack, I'll change in next version

>>  				compatible = "arm,idle-state";
>>  				local-timer-stop;
>>  				arm,psci-suspend-param = <0x01010001>;
>> @@ -176,7 +176,7 @@ CLUSTER_SLEEP0: cluster-sleep@0 {
>>  				exit-latency-us = <400>;
>>  				min-residency-us = <1000>;
>>  			};
>> -			CLUSTER_SLEEP1: cluster-sleep@1 {
>> +			CLUSTER_SLEEP1: cluster-sleep1 {
> 
> Same here.
> 

Ack.

> Regards,
> Matthias1
> 
>>  				compatible = "arm,idle-state";
>>  				local-timer-stop;
>>  				arm,psci-suspend-param = <0x01010001>;
>>