Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1313650ybt; Thu, 25 Jun 2020 03:06:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfN9AkNljYeiJJ3lryJEPcAdc7PIGbp45HfJP5UcvZl57lsx+M4RrB4b6x2axoJcdAwQxH X-Received: by 2002:aa7:ccc2:: with SMTP id y2mr30240989edt.97.1593079596034; Thu, 25 Jun 2020 03:06:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593079596; cv=none; d=google.com; s=arc-20160816; b=ZFYXjFJUwMHHvLoX2mstX9f3PJDG/bUDZICb6HnKLcinmfVGpmpRFzu82ESkw4i0zv H364Xv0OSm3aA+ip/hgQmdcp0TtRyQnsPqH9h/pmO6pLuRQfE554REwg2LeqysuUlZKu 9JntNXqihaRqp0U1qmnO/gx1U1HYDmtA0ztxgji8m0Rea5R3jOfdRq7AIFKCVv6huy1q 99Kf0yrM2DsXmtkWi5iV8m1FVsBtvoUk38trUiJGnTv6xk6j4SCXwofZpInO1PE++9wU ng22OEDVRPH42Ya7gJrS5VPkmMdUdVg+qHSJ9zX3tT0M349yfsG+kfGvx21ix0oRbQwc LfgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ybj+b59PtEODY6ZUxbXfzCu2fuJ9rY9PDTaittCHxMk=; b=K5XPApTOGlAJjsIXoFR4W940FtFE3PXlqiGrlMWf8/D1aYlDzOebk/N1/40X1jv8Ki nRRr8NhU8NGxj0cU4ELygRpqhgdn+8fwKVDl/rnjoDaH/aY61mYTxTahqLcl+BBC3Gfv POgnJtGTBZTKhl2tRolx78FXtJcfttFgrQBcAS6do6GoyNSVijabjOmRuytaX6KNhuNf /yanMPXqLZ9q4YkcvfnUEHuab2XDAma0mKbnm8EHvwRPErcK00smSXTmvMg3f+pz9r0E qlHOiDWbfRKCyCOB99/PeJNKl7Eoi70Nlb2bVFXRptzvVBeuK1io2NlTfAdOMdDuiTWY V4Dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=UG8w6M3V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cc13si5609744edb.297.2020.06.25.03.06.12; Thu, 25 Jun 2020 03:06:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=UG8w6M3V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390740AbgFYJr3 (ORCPT + 99 others); Thu, 25 Jun 2020 05:47:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390052AbgFYJr2 (ORCPT ); Thu, 25 Jun 2020 05:47:28 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FFF3C061573; Thu, 25 Jun 2020 02:47:28 -0700 (PDT) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3BE2C521; Thu, 25 Jun 2020 11:47:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1593078445; bh=Rd6+/EiGtZUUer4Z7+8mWfSC18i6Ms0DFb9zau1uDdM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UG8w6M3V8VNc3AN7Br+6+dNZDthnouJVTanLFWakrkvOVbZv+hJOpdJhllO8IzUhN 4dI05+mZo182HoEIt9uuuYB0fMPbQjOK6ZhR/Mn6RfBbwMhbrFnOCd2pjSPcgmik65 LqWRlwz5C32wYvyxhLxjZNP/yEHEEhBs/h1z4Sl0= Date: Thu, 25 Jun 2020 12:47:24 +0300 From: Laurent Pinchart To: Ramzi Ben Meftah Cc: Jacopo Mondi , niklas soderlund , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , Janusz Krzysztofik , Steve Longerbeam , Ezequiel Garcia , Arnd Bergmann , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Rodin , efriedrich@de.adit-jv.com, erosca@de.adit-jv.com Subject: Re: [PATCH 1/3] v4l2-subdev: Add subdev ioctl support for ENUM/GET/SET INPUT Message-ID: <20200625094724.GE5865@pendragon.ideasonboard.com> References: <1592301619-17631-1-git-send-email-rbmeftah@de.adit-jv.com> <20200624075307.hl6wew7vr5ue225t@uno.localdomain> <20200625020138.GW5980@pendragon.ideasonboard.com> <20200625093046.GA91893@vmlxhi-110.adit-jv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200625093046.GA91893@vmlxhi-110.adit-jv.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ramzi, On Thu, Jun 25, 2020 at 11:30:46AM +0200, Ramzi Ben Meftah wrote: > On Thu, Jun 25, 2020 at 05:01:38AM +0300, Laurent Pinchart wrote: > > On Wed, Jun 24, 2020 at 09:53:07AM +0200, Jacopo Mondi wrote: > >> On Tue, Jun 16, 2020 at 12:00:15PM +0200, Ramzi BEN MEFTAH wrote: > >>> From: Steve Longerbeam > >> > >> +Niklas, +Laurent > >> > >> Niklas, Laurent, how does this play with CAP_IO_MC ? > > > > I don't think it's related to CAP_IO_MC, but I don't think it's a good > > idea either :-) Routing doesn't go through the subdev [gs]_input > > operations in MC-based drivers. It should be configured through link > > setup instead. This patch goes in the wrong direction, sorry Steve. > > ENUMINPUT ioctl allow to get the input signal status. Is there an alternative > with Media Controller? No there isn't at the moment. I'm not opposed to adding such a feature, but VIDIOC_ENUMINPUT isn't the right choice. This would have to be a subdev pad operation (v4l2_subdev_pad_ops), not a video operation (v4l2_subdev_video_ops). We also likely shouldn't call it "enum" input, as it would retrieve properties of the input corresponding to the pad, not enumerate inputs. > >>> This commit enables VIDIOC_ENUMINPUT, VIDIOC_G_INPUT, and VIDIOC_S_INPUT > >>> ioctls for use via v4l2 subdevice node. > >>> > >>> This commit should probably not be pushed upstream, because the (old) > >>> idea of video inputs conflicts with the newer concept of establishing > >>> media links between src->sink pads. > >>> > >>> However it might make sense for some subdevices to support enum/get/set > >>> inputs. One example would be the analog front end subdevice for the > >>> ADV748x. By providing these ioctls, selecting the ADV748x analog inputs > >>> can be done without requiring the implementation of media entities that > >>> would define the analog source for which to establish a media link. > >>> > >>> Signed-off-by: Steve Longerbeam > >>> --- > >>> drivers/media/v4l2-core/v4l2-subdev.c | 9 +++++++++ > >>> include/media/v4l2-subdev.h | 11 +++++++++++ > >>> 2 files changed, 20 insertions(+) > >>> > >>> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c > >>> index 6b989fe..73fbfe9 100644 > >>> --- a/drivers/media/v4l2-core/v4l2-subdev.c > >>> +++ b/drivers/media/v4l2-core/v4l2-subdev.c > >>> @@ -378,6 +378,15 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg) > >>> return -ENOTTY; > >>> return v4l2_querymenu(vfh->ctrl_handler, arg); > >>> > >>> + case VIDIOC_ENUMINPUT: > >>> + return v4l2_subdev_call(sd, video, enuminput, arg); > >>> + > >>> + case VIDIOC_G_INPUT: > >>> + return v4l2_subdev_call(sd, video, g_input, arg); > >>> + > >>> + case VIDIOC_S_INPUT: > >>> + return v4l2_subdev_call(sd, video, s_input, *(u32 *)arg); > >>> + > >>> case VIDIOC_G_CTRL: > >>> if (!vfh->ctrl_handler) > >>> return -ENOTTY; > >>> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h > >>> index f7fe78a..6e1a9cd 100644 > >>> --- a/include/media/v4l2-subdev.h > >>> +++ b/include/media/v4l2-subdev.h > >>> @@ -383,6 +383,14 @@ struct v4l2_mbus_frame_desc { > >>> * @g_input_status: get input status. Same as the status field in the > >>> * &struct &v4l2_input > >>> * > >>> + * @enuminput: enumerate inputs. Should return the same input status as > >>> + * @g_input_status if the passed input index is the currently active > >>> + * input. > >>> + * > >>> + * @g_input: returns the currently active input index. > >>> + * > >>> + * @s_input: set the active input. > >>> + * > >>> * @s_stream: used to notify the driver that a video stream will start or has > >>> * stopped. > >>> * > >>> @@ -423,6 +431,9 @@ struct v4l2_subdev_video_ops { > >>> int (*g_tvnorms)(struct v4l2_subdev *sd, v4l2_std_id *std); > >>> int (*g_tvnorms_output)(struct v4l2_subdev *sd, v4l2_std_id *std); > >>> int (*g_input_status)(struct v4l2_subdev *sd, u32 *status); > >>> + int (*enuminput)(struct v4l2_subdev *sd, struct v4l2_input *input); > >>> + int (*g_input)(struct v4l2_subdev *sd, u32 *index); > >>> + int (*s_input)(struct v4l2_subdev *sd, u32 index); > >>> int (*s_stream)(struct v4l2_subdev *sd, int enable); > >>> int (*g_pixelaspect)(struct v4l2_subdev *sd, struct v4l2_fract *aspect); > >>> int (*g_frame_interval)(struct v4l2_subdev *sd, -- Regards, Laurent Pinchart