Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1321848ybt; Thu, 25 Jun 2020 03:18:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4k3bGPtGvMALKvkCsFA1xDOjd1b98qObvfrxxPb2K6/RPzyt5DAUs50V8JF1GGWlOxMI9 X-Received: by 2002:a17:906:dbed:: with SMTP id yd13mr5785024ejb.419.1593080326440; Thu, 25 Jun 2020 03:18:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593080326; cv=none; d=google.com; s=arc-20160816; b=VbQipVU7I1F7eWBokSGstWUb0Yqpvjmk7h1ArwxHq6Z61ne0mI8Foz81UCj9uYK0UH 1wzgmy5UM1mkpv9bTEjc6SFMaVELgpqtPqR/ik/tzPGxR7hhf6NYVjSfbd5qyajbEb34 oVN/yrzLPnW2NOQ6trN1gzTDGCayz+ke9N/V3TI7r0H6bkief44PY26hZG0nwJ3rnTxT fAToWknQRrYXGzaCHF4Nuzv+EV/A27nNY3vPoDCJwo8AMyNCad1ALKjBwfagiSAhT6ja ZYqO7pcWsAIg60976eH4y4YR5JHxVHDqSHarVF2uCh9UQshc6b81u/o9F9kiumGVG1Gs Eb8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=wZEaiRB22xa7BcRCKe3HuRHsBBwhLUBTrmGUHGuXtCI=; b=x8E99ryRdAxBGKo0JEStRf+37ELw3QW3P3ocX6PBqPtD8WQY7RqYvKWKMks5XsQ0OI +do/uMZjOBp+6em4Be1ii6qZxHQv+KHV8nRmSbqOOqH64u57MM7XO0nlsOKyiKbXPELt PKjnrlxqZ4HqwtCu/Uxgk7B8Gal1Sdy4TD/EfpVBVBpbQOHIqd+PAE7oXE2xGniWECN3 gyrVVJJb9WT2vjj/A+qJwcen1QMBZidVg5G6o1fg0EbKxuSIs5Azrdbn/5NwiFYgUy70 sEjHiCh09WKlAqb1xP61ccctN7IpMt0J2MPIc1GJvdNrQ9Y35aS+IDclxPbcKvl9YKuG cLTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=cbJ49egf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm7si8974977edb.43.2020.06.25.03.18.22; Thu, 25 Jun 2020 03:18:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=cbJ49egf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390789AbgFYKOx (ORCPT + 99 others); Thu, 25 Jun 2020 06:14:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389773AbgFYKOw (ORCPT ); Thu, 25 Jun 2020 06:14:52 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7431C061573; Thu, 25 Jun 2020 03:14:51 -0700 (PDT) Received: from zn.tnic (p200300ec2f0ed100f934f9e71bd17243.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:d100:f934:f9e7:1bd1:7243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3CA8F1EC0105; Thu, 25 Jun 2020 12:14:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1593080088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=wZEaiRB22xa7BcRCKe3HuRHsBBwhLUBTrmGUHGuXtCI=; b=cbJ49egfsTPDPA0eCEA0nvoKG0L2FvTzOqmQ1yrjTlmOhslozoqWySWPgieVp8Em0SEAof ME8e1WsY05VUCZC/NKer/BvgX1PHHN4HSUuk0GpRcJYtb0gnPDGBpCEOPcSkj4xyadZQoQ k+CoLRo9sqUZhyl2CvBE4p5nQUpYpxA= Date: Thu, 25 Jun 2020 12:14:41 +0200 From: Borislav Petkov To: Jarkko Sakkinen Cc: x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Christopherson , Jethro Beekman , Serge Ayoun , akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, asapek@google.com, cedric.xing@intel.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, dave.hansen@intel.com, haitao.huang@intel.com, josh@joshtriplett.org, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, npmccallum@redhat.com, puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com Subject: Re: [PATCH v33 08/21] x86/sgx: Initialize metadata for Enclave Page Cache (EPC) sections Message-ID: <20200625101441.GC20319@zn.tnic> References: <20200617220844.57423-1-jarkko.sakkinen@linux.intel.com> <20200617220844.57423-9-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200617220844.57423-9-jarkko.sakkinen@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 18, 2020 at 01:08:30AM +0300, Jarkko Sakkinen wrote: > +static inline struct sgx_epc_section *sgx_get_epc_section( > + struct sgx_epc_page *page) Just let it stick out - breaking lines on arg opening brace are the ugliest. Also: bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning") Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette