Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] media: i2c: tvp5150: Fix horizontal crop stop boundry
To:     Robin van der Gracht <robin@protonic.nl>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Marco Felsch <m.felsch@pengutronix.de>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Andreas Pretzsch <apr@cn-eng.de>
References: <20190917071442.24986-1-robin@protonic.nl>
From:   Hans Verkuil <hverkuil@xs4all.nl>
Message-ID: <23cbd4c0-b53e-d01f-e6d6-b4d2d689bb59@xs4all.nl>
Date:   Thu, 25 Jun 2020 13:05:22 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20190917071442.24986-1-robin@protonic.nl>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 17/09/2019 09:14, Robin van der Gracht wrote:
> The value for AVID stop is relative to the width of the active video area,
> not the maximum register value. Zero means equal and a negative value means
> we're cropping on the right side.

While going through old unreviewed patches I came across this one (sorry Robin,
your patch fell through the cracks).

Can someone verify/test that this is correct? Marco perhaps?

Regards,

	Hans

> 
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> ---
>  drivers/media/i2c/tvp5150.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index f47cb9a023fb..6bc65ab5e8ab 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -1231,10 +1231,10 @@ __tvp5150_set_selection(struct v4l2_subdev *sd, struct v4l2_rect rect)
>  	regmap_write(decoder->regmap, TVP5150_ACT_VD_CROP_ST_LSB,
>  		     rect.left | (1 << TVP5150_CROP_SHIFT));
>  	regmap_write(decoder->regmap, TVP5150_ACT_VD_CROP_STP_MSB,
> -		     (rect.left + rect.width - TVP5150_MAX_CROP_LEFT) >>
> +		     (rect.left + rect.width - TVP5150_H_MAX) >>
>  		     TVP5150_CROP_SHIFT);
>  	regmap_write(decoder->regmap, TVP5150_ACT_VD_CROP_STP_LSB,
> -		     rect.left + rect.width - TVP5150_MAX_CROP_LEFT);
> +		     rect.left + rect.width - TVP5150_H_MAX);
>  }
>  
>  static int tvp5150_set_selection(struct v4l2_subdev *sd,
>