Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: sL0nCXh94Xxcq4Msp+WHmtnQ7nZ6pcp1ZAN48I0y4MNZxyT4WOZn2YuC06rQwV2ShGqIYVey54
 l28052WjK4mSfqYTXrT354qBTvOkK4XYPoznewkYMQjMA9eSzn8iYmmTyHEeTIfQ8cHNNP3kYZ
 b5g1Al5zkAvIVT83QE54lD+LCK6AatZKFRlDAooE+44Ye0agsoB6I/k2470zJnyDP4Q67FWbvU
 jyJ9oIRSAZp6K8KWLnyfk4uKzWcmGZBvDlmW0RtG2bCp7ZEyNqo2LD12h3sTJv6hrOkhwV08Oc
 1zU=
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
CC:     Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
        Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@fb.com>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] remove workarounds for gcc bug wrt unnamed fields
 in initializers
Thread-Topic: [PATCH v2 0/2] remove workarounds for gcc bug wrt unnamed fields
 in initializers
Thread-Index: AQHWRatsK9pqpN/HlEmT0NtnEgioaqjpNw0A
Date:   Thu, 25 Jun 2020 11:10:15 +0000
Message-ID: <20200625111012.GA418830@localhost.localdomain>
References: <20200618200235.1104587-1-niklas.cassel@wdc.com>
 <20200624164441.GA24816@lst.de>
 <BYAPR04MB49655BD99E428B66EBB831E486950@BYAPR04MB4965.namprd04.prod.outlook.com>
In-Reply-To: <BYAPR04MB49655BD99E428B66EBB831E486950@BYAPR04MB4965.namprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BE0752A3B563674095CC7361BDAE4655@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ad2e133a-34c1-45d1-7d31-08d818f856cb
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2020 11:10:15.8288
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GhwvoCJxv5Gv3Ib2DX8LvuFqwQ/SWXAY768x2IseIxRiXUdWzYqS24+kYkImSwXfAzF81lM2zMpPINCJ61U3GQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6294
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 24, 2020 at 10:40:21PM +0000, Chaitanya Kulkarni wrote:
> Christoph, Sagi and Keith,
>=20
> On 6/24/20 9:44 AM, Christoph Hellwig wrote:
> > This looks good to me, but I'd rather wait a few releases to
> > avoid too mush backporting pain.
> >=20
>=20
> Here is a summary, for longer explanation please have a look at the
> end [1] :-
>=20
> Pros:
> 1. Code looks uniform and follows strict policy.
>=20
> Cons:
> 1. Adds a tab + more char [1] which can lead to line breaks and that can
>     be avoided without following declare-init pattern, less bugs and
>     no pressure to fit the initializer in ~72 char given that we do have
>     some long names and who knows what is in the future.

[BEGIN being silly.. sorry guys, I couldn't resist.. :)]

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/s=
cripts/checkpatch.pl?id=3Dbdc48fa11e46f867ea4d75fa59ee87a7f48be144

Isn't 100 the new 80? ;)

[END being silly]=