Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1394425ybt; Thu, 25 Jun 2020 05:10:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsM7iNlWXfO27vwEid9/3zLXfg/8u278JtO3YMP1380OxNxTJnXfhEryeCqh1unlR37IxY X-Received: by 2002:a50:aca6:: with SMTP id x35mr10815935edc.328.1593087020337; Thu, 25 Jun 2020 05:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593087020; cv=none; d=google.com; s=arc-20160816; b=UdcW1tn1pI9bM64MuTnbqcTtjRE558aFKzIbQ1tcAhTXvGvFeHoASNWEdLO27W5Eju Wn/K6BnzNpVh7+DVA7nvQc2IY58RKTNlzvY/44GNvqRZnisT2cmyl595pM1+i0piV2bW dCU59G7MS6Xd5j47g2WqGkFVPvTqKeNgfSTRh5PNeewNiQGdtvY7OWKCKSZuoMse09RI maonRg0knoe/V3joPTKXMSLrsFKzB8mzI2irDkoSBobm0fKFSvmrIIUr81FuH46mbiQN AGpj/PFGRQXhs9Rzv+Gkko7Ap81179GQW3ez7fhnQBMFeWPCJBG8tvEirSNto3rfdVit u71Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=UKCFODb5/EwXV72SoexoF57zFObV5cMgCmwfT5dAPbA=; b=qO2tE9530lHaV7vtipFGH+qehLlgQN1Qgtf5S1t5G3AKxt+e/CqADI8AsiqGwch/DR GtQ2amW+BxpB1Eg3zocgVww/DXp8o9K20ch8fWpBW5LGoJIOQVRbMxAfKIl1CLsdR0uj AbMO9VV7edWXHSP5WhN2cjqeN93TUU7FLxDuOFBMEH4TllAyX7fdwP4AWAi9iASql2cz 54ZxdT/dQxjmZZk0Ev++Hk7213HIe5L4h7GPCvniTt/qWnpTy0UexNHJYiHypfbxMj6h 3GEccN1TqH7hyzYi9p2jP1qYmddfOiQ9/BKvx+TRDHSuRWOIReTCLzGn22pzv/w4E08+ lIgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d4si9296816ejb.349.2020.06.25.05.09.55; Thu, 25 Jun 2020 05:10:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404476AbgFYMId (ORCPT + 99 others); Thu, 25 Jun 2020 08:08:33 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:45795 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404222AbgFYMId (ORCPT ); Thu, 25 Jun 2020 08:08:33 -0400 Received: by mail-ej1-f67.google.com with SMTP id a1so5656087ejg.12 for ; Thu, 25 Jun 2020 05:08:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UKCFODb5/EwXV72SoexoF57zFObV5cMgCmwfT5dAPbA=; b=VlkoRLGP6ZTOgAz63/va2pc4PSf7wavjTDUO4sstRpYOE945TOoxkqED4phFOZ+PNf N8QJALIMq7qIX2DIearHsXI8eyFXSW6wE+s5X41/sV2pkXK0a+vwgL1o2LznQqhMPeTR Lc0ftVp4F+lY+Ee2OoMMgmB/YCFzrn6BR5GSvMXvji5ubIWonqAE/KdaCgGg0kvRfPMP mE/yJm1Rldrr1GZN8G7baYFUEotF7P4oOuJ9nqf8i31FTaFmIS8LD2LFsQBDzyeKANtb QPjxbY/a66TnpQ+/TOM/RaOk7/3v+dyFK1zbqczraG5PWXfzKCaB6XPTCfMRaL/RAmyn DsXQ== X-Gm-Message-State: AOAM533pY4BZdagNjm7jqeNFLQ0WLtWMNKwk6Li7loeoqMMJ+JZXtwtE p2w55+/Srhg4KgYkbaN09Jw= X-Received: by 2002:a17:906:c672:: with SMTP id ew18mr30511084ejb.404.1593086911908; Thu, 25 Jun 2020 05:08:31 -0700 (PDT) Received: from localhost (ip-37-188-168-3.eurotel.cz. [37.188.168.3]) by smtp.gmail.com with ESMTPSA id v24sm3012701eja.29.2020.06.25.05.08.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 05:08:31 -0700 (PDT) Date: Thu, 25 Jun 2020 14:08:30 +0200 From: Michal Hocko To: js1304@gmail.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@lge.com, Vlastimil Babka , Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Joonsoo Kim Subject: Re: [PATCH v3 6/8] mm/gup: use a standard migration target allocation callback Message-ID: <20200625120830.GG1320@dhcp22.suse.cz> References: <1592892828-1934-1-git-send-email-iamjoonsoo.kim@lge.com> <1592892828-1934-7-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1592892828-1934-7-git-send-email-iamjoonsoo.kim@lge.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 23-06-20 15:13:46, Joonsoo Kim wrote: > From: Joonsoo Kim > > There is a well-defined migration target allocation callback. > It's mostly similar with new_non_cma_page() except considering CMA pages. > > This patch adds a CMA consideration to the standard migration target > allocation callback and use it on gup.c. We already can express that by a missing __GFP_MOVABLE so I would rather not introduce a duplication in form of another flag. -- Michal Hocko SUSE Labs