Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 25 Jun 2020 06:22:26 -0700
From:   Richard Cochran <richardcochran@gmail.com>
To:     Antoine Tenart <antoine.tenart@bootlin.com>
Cc:     davem@davemloft.net, andrew@lunn.ch, f.fainelli@gmail.com,
        hkallweit1@gmail.com, alexandre.belloni@bootlin.com,
        UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
        allan.nielsen@microchip.com, foss@0leil.net
Subject: Re: [PATCH net-next v4 6/8] net: phy: mscc: timestamping and PHC
 support
Message-ID: <20200625132226.GC2548@localhost>
References: <20200623143014.47864-1-antoine.tenart@bootlin.com>
 <20200623143014.47864-7-antoine.tenart@bootlin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200623143014.47864-7-antoine.tenart@bootlin.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 23, 2020 at 04:30:12PM +0200, Antoine Tenart wrote:
> @@ -978,9 +1483,32 @@ static int __vsc8584_init_ptp(struct phy_device *phydev)
>  
>  	vsc85xx_ts_eth_cmp1_sig(phydev);
>  
> +	vsc8531->mii_ts.rxtstamp = vsc85xx_rxtstamp;
> +	vsc8531->mii_ts.txtstamp = vsc85xx_txtstamp;
> +	vsc8531->mii_ts.hwtstamp = vsc85xx_hwtstamp;
> +	vsc8531->mii_ts.ts_info  = vsc85xx_ts_info;
> +	phydev->mii_ts = &vsc8531->mii_ts;
> +
> +	memcpy(&vsc8531->ptp->caps, &vsc85xx_clk_caps, sizeof(vsc85xx_clk_caps));
> +
> +	vsc8531->ptp->ptp_clock = ptp_clock_register(&vsc8531->ptp->caps,
> +						     &phydev->mdio.dev);
> +	if (IS_ERR(vsc8531->ptp->ptp_clock))
> +		return PTR_ERR(vsc8531->ptp->ptp_clock);

The ptp_clock_register() method can also return NULL:

 * Returns a valid pointer on success or PTR_ERR on failure.  If PHC
 * support is missing at the configuration level, this function
 * returns NULL, and drivers are expected to gracefully handle that
 * case separately.

Thanks,
Richard