Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1449651ybt; Thu, 25 Jun 2020 06:28:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhr++ak/2YPZbY2npQ8qjvdWpg9BTFTgE5f6nHw8pXJ8N2nEL6EVw1eCvFV4qG1BloGU0/ X-Received: by 2002:a17:906:fcba:: with SMTP id qw26mr16277813ejb.112.1593091691634; Thu, 25 Jun 2020 06:28:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593091691; cv=none; d=google.com; s=arc-20160816; b=Q+0JpDbklI3iKGLuIg9EHemKxwYh7QYmTKFOup+XGhTVzTiE6V4UNxQBkCSz1iiHQk JszYkqBaeEwunfXukhtiLUqKzuOxiRCDAZhBMm8OmQarQx1yekACfgkFDRgGjEIfmnKA UnRoCaJtJNEdgIN7XhZw3nKLj2EjcQdbUQ9aJzdtgwZpS8x6xzIEIwGdacUkuO3Xu7Ko tCsVdQ1hKwxHuitJa+66o33G8kQGSPswdiJ/Pmikqm5Fq6Ptab6HAC97Shx2mMQMrmng +kaetep64lTZWf4Wi1oP3RqrLHw0cJjeWBXad0tP/pVsC5sLY4fctYLq00/pBOX2/+tC ulcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=eWSfWI4wpEme8MrwfvQ7LPuMKGxIgLayOyX6JwETS9k=; b=0PmgMreUlN9GVwT2/bBtUCJelkP3JEi3BV9koPn71sejwqH/4PZ1DNRd9Hm3oWcM6K lTCLj68ft/QAf5fXNBjqQ9pZRMcQHV15AZijFIDHtEjQvZVzL8U+09D9APDFFE8QYI9l DlqSiccHTMI7A9EB0VrxOmHxt8/BE6z2LlCLRtif+EaEw4kfAB11r+l3g+g2YqKisjAo WWEE9sIkywfUWkBjbM7e6imFi2g+rcyA6/GsoUuT83O6aGf+Ubb0wCMl+Ku3n4kThiDK zSkamyJGo5Q8DaNM2x/1Tit3yWKB1totKpEfQm6hcq0e+oMO0Q017OfG4T7UJvTQo+4D maMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=TXs317Ch; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x15si16225914edj.153.2020.06.25.06.27.47; Thu, 25 Jun 2020 06:28:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=TXs317Ch; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404993AbgFYNY2 (ORCPT + 99 others); Thu, 25 Jun 2020 09:24:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404935AbgFYNY1 (ORCPT ); Thu, 25 Jun 2020 09:24:27 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7623BC08C5DB for ; Thu, 25 Jun 2020 06:24:26 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id b92so3209729pjc.4 for ; Thu, 25 Jun 2020 06:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=eWSfWI4wpEme8MrwfvQ7LPuMKGxIgLayOyX6JwETS9k=; b=TXs317Chw7NlZME2mN7859gja5QL9DFyQzGIbvLyC0Z35kZPOYP34joAI5KMOaN5PK Y77JHyvhP0f0iy4PPvYyb3iqfJhnEeW3XAc/Yq4Mo6Plmgmrc3xGo58DDXeQ85sneA47 PJPwd2z3+2sBXiPkmSRiEmNcu7THXZR/EyE43riF8IF51yLxi9ckeQh1tzSL36Zp2OZd Y2WdMe051I5Rir1G6lfaQ5QnuC0igLb9IuHs4cFtpBkSN02avQR1M/U9A7IsJQ3qWikQ QO54UdFpQW+EBxCNjZ11lXroQgTPm+3/aPJPO+A6aI0CijcjTfwCCGbumI9waZ7JDcp4 gMog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eWSfWI4wpEme8MrwfvQ7LPuMKGxIgLayOyX6JwETS9k=; b=fQ3z/v7uOjuzFAXIQA4jjEy56LQmNuXWM0v/aLE17gJDZkQz7Zcq1md1xIvjCNx9j4 nguLkYoaf1ed80AUEAgxyb4psb+7+7I+ajZS56HYktTPZtXb0L8ro6udRe1SlIGaDC6w ELatFY75wokTYLNNfn2P4zpsbOoDHtc9tkOd84OiavsmBg64ymWeu85zbzuPbkg2wj8A Pv54Fi315GCSOmpcf0kComRmfIerhuOG1+WgOHhraSmVNy411/NO0GIc/hhH/txJYfvC GBFkEVUk4hSnfVZC7ExS0XkPVx5ol6WViNqEGHvMJYdhgl79WoMgyhQh/Z8mo+g8UKXu BXFA== X-Gm-Message-State: AOAM531k9hbkn0CMlHUPJKtnHNKFyCCmQOt2tfezMOAW92h1PeIWOYO4 H/3gyiGkfBdjWdsrgQjs21DgGq5LS1bAjA== X-Received: by 2002:a17:902:8690:: with SMTP id g16mr33052502plo.257.1593091465728; Thu, 25 Jun 2020 06:24:25 -0700 (PDT) Received: from ?IPv6:2600:380:6c49:6812:d113:f43c:df53:19ee? ([2600:380:6c49:6812:d113:f43c:df53:19ee]) by smtp.gmail.com with ESMTPSA id h5sm24249689pfb.120.2020.06.25.06.24.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2020 06:24:24 -0700 (PDT) Subject: Re: [PATCH 5.9] io_uring: fix NULL-mm for linked reqs To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <41f3f2db-bc1c-22cc-d93c-4ed31cfb225f@kernel.dk> Date: Thu, 25 Jun 2020 07:24:21 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/25/20 3:38 AM, Pavel Begunkov wrote: > __io_queue_sqe() tries to handle all request of a link, > so it's not enough to grab mm in io_sq_thread_acquire_mm() > based just on the head. > > Don't check req->needs_mm and do it always. Applied, thanks. -- Jens Axboe